Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add currSqrtPrice to LiquidityNetInDirection return value #6692

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

czarcas7ic
Copy link
Member

@czarcas7ic czarcas7ic commented Oct 13, 2023

Closes: #XXX

What is the purpose of the change

Adds currSqrtPrice to LiquidityNetInDirection return value

@czarcas7ic czarcas7ic added A:backport/v19.x backport patches to v19.x branch A:backport/v20.x backport patches to v20.x branch labels Oct 13, 2023
@czarcas7ic czarcas7ic changed the title chore: add cur sqrt price to return chore: add cur sqrt price to LiquidityNetInDirection return value Oct 13, 2023
Copy link
Member

@p0mvn p0mvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@czarcas7ic czarcas7ic added the V:state/compatible/backport State machine compatible PR, should be backported label Oct 13, 2023
@czarcas7ic czarcas7ic marked this pull request as ready for review October 13, 2023 16:59
@czarcas7ic czarcas7ic changed the title chore: add cur sqrt price to LiquidityNetInDirection return value chore: add currSqrtPrice to LiquidityNetInDirection return value Oct 13, 2023
@czarcas7ic czarcas7ic merged commit c06f809 into main Oct 13, 2023
1 check passed
@czarcas7ic czarcas7ic deleted the adam/return-cur-sqrt-price-query branch October 13, 2023 17:08
mergify bot pushed a commit that referenced this pull request Oct 13, 2023
* add cur sqrt price to return

* add changelog entry

(cherry picked from commit c06f809)

# Conflicts:
#	x/concentrated-liquidity/client/queryproto/query.pb.go
mergify bot pushed a commit that referenced this pull request Oct 13, 2023
* add cur sqrt price to return

* add changelog entry

(cherry picked from commit c06f809)
czarcas7ic added a commit that referenced this pull request Oct 13, 2023
…) (#6694)

* add cur sqrt price to return

* add changelog entry

(cherry picked from commit c06f809)

Co-authored-by: Adam Tucker <[email protected]>
czarcas7ic added a commit that referenced this pull request Oct 13, 2023
…kport #6692) (#6693)

* chore: add currSqrtPrice to LiquidityNetInDirection return value (#6692)

* add cur sqrt price to return

* add changelog entry

(cherry picked from commit c06f809)

# Conflicts:
#	x/concentrated-liquidity/client/queryproto/query.pb.go

* Generated protofile changes

---------

Co-authored-by: Adam Tucker <[email protected]>
Co-authored-by: github-actions <[email protected]>
pysel pushed a commit that referenced this pull request Oct 17, 2023
* add cur sqrt price to return

* add changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v19.x backport patches to v19.x branch A:backport/v20.x backport patches to v20.x branch C:CLI C:x/concentrated-liquidity V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants