Add Taker Fee Query #6680
Merged
Add Taker Fee Query #6680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattverse
requested review from
czarcas7ic,
p0mvn and
AlpinYukseloglu
as code owners
|
devbot help |
czarcas7ic
reviewed
Oct 12, 2023
czarcas7ic
reviewed
Oct 12, 2023
czarcas7ic
reviewed
Oct 12, 2023
Co-authored-by: Adam Tucker <[email protected]>
Co-authored-by: Adam Tucker <[email protected]>
|
I didn't add CLI on purpose(didn't see any need for it), but on the second thought, why not :) |
czarcas7ic
approved these changes
Oct 13, 2023
mergify bot
pushed a commit
that referenced
this pull request
Oct 13, 2023
* Add trader fee query * Generated protofile changes * Add Taker fee * Add querier logic * Generated protofile changes * Add grpc guery.go * Generated protofile changes * Update proto/osmosis/poolmanager/v1beta1/query.proto Co-authored-by: Adam Tucker <[email protected]> * Update proto/osmosis/poolmanager/v1beta1/query.proto Co-authored-by: Adam Tucker <[email protected]> * Add cli * Generated protofile changes * register query in query server --------- Co-authored-by: github-actions <[email protected]> Co-authored-by: Adam Tucker <[email protected]> Co-authored-by: Adam Tucker <[email protected]> (cherry picked from commit 144e088)
czarcas7ic
pushed a commit
that referenced
this pull request
Oct 13, 2023
* Add trader fee query * Generated protofile changes * Add Taker fee * Add querier logic * Generated protofile changes * Add grpc guery.go * Generated protofile changes * Update proto/osmosis/poolmanager/v1beta1/query.proto Co-authored-by: Adam Tucker <[email protected]> * Update proto/osmosis/poolmanager/v1beta1/query.proto Co-authored-by: Adam Tucker <[email protected]> * Add cli * Generated protofile changes * register query in query server --------- Co-authored-by: github-actions <[email protected]> Co-authored-by: Adam Tucker <[email protected]> Co-authored-by: Adam Tucker <[email protected]> (cherry picked from commit 144e088) Co-authored-by: Matt, Park <[email protected]>
pysel
pushed a commit
that referenced
this pull request
Oct 17, 2023
* Add trader fee query * Generated protofile changes * Add Taker fee * Add querier logic * Generated protofile changes * Add grpc guery.go * Generated protofile changes * Update proto/osmosis/poolmanager/v1beta1/query.proto Co-authored-by: Adam Tucker <[email protected]> * Update proto/osmosis/poolmanager/v1beta1/query.proto Co-authored-by: Adam Tucker <[email protected]> * Add cli * Generated protofile changes * register query in query server --------- Co-authored-by: github-actions <[email protected]> Co-authored-by: Adam Tucker <[email protected]> Co-authored-by: Adam Tucker <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
Adds taker fee query and add it to stargate whitelist.
Needed for necessary calculations for all contracts that have dependency on calculation.
Testing and Verifying
This change is a trivial rework / code cleanup without any test coverage.
Documentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)