Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Execute Method to cosmos-sdk #666

Merged
merged 3 commits into from
Dec 19, 2021
Merged

Change Execute Method to cosmos-sdk #666

merged 3 commits into from
Dec 19, 2021

Conversation

mattverse
Copy link
Member

Closes: #523

Description

Unlike most Cosmos SDK based chains, osmosis did not have global flags for log-format and log-level to specify log settings.
This was basically because we had our own method of initializing Cmd in our repo, which was a duplicate method from the sdk.

Thus this PR removes the Execute method that was defined seperately in osmosis and moves the dependency to osmosis-labs/cosmos-sdk, supporting log-format and log-level when running an Osmosis node.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@codecov-commenter
Copy link

Codecov Report

Merging #666 (76ec055) into main (4641e15) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #666   +/-   ##
=======================================
  Coverage   18.41%   18.41%           
=======================================
  Files         172      172           
  Lines       24257    24257           
=======================================
  Hits         4467     4467           
  Misses      19023    19023           
  Partials      767      767           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4641e15...76ec055. Read the comment docs.

Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Can you add a changelog entry, then we can go ahead and merge this

@ValarDragon ValarDragon merged commit 74e5932 into main Dec 19, 2021
@ValarDragon ValarDragon deleted the mattverse/log-format branch December 19, 2021 21:51
ValarDragon pushed a commit that referenced this pull request Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Enable --log_format flag
3 participants