Change Execute Method to cosmos-sdk #666
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #523
Description
Unlike most Cosmos SDK based chains, osmosis did not have global flags for log-format and log-level to specify log settings.
This was basically because we had our own method of initializing Cmd in our repo, which was a duplicate method from the sdk.
Thus this PR removes the
Execute
method that was defined seperately in osmosis and moves the dependency to osmosis-labs/cosmos-sdk, supportinglog-format
andlog-level
when running an Osmosis node.For contributor use:
docs/
) or specification (x/<module>/spec/
)Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorer