-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(poolmanager): taker fee reduction whitelist #6632
Conversation
Important Notice This PR modifies an in-repo Go module. It is one of:
The dependent Go modules, especially the root one, will have to be Please follow the instructions below:
Please let us know if you need any help. |
// | ||
// Returns: | ||
// - An error if any of the strings are not addresses | ||
func ValidateAddressList(i interface{}) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: copied from the x/concentrated-liquidity to reduce code duplication
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, would like the name change in order to make the next step of adding a percent reduction more seamless (and just thinking of the current implementation as a 100 percent reduction)
Closes: #XXX
What is the purpose of the change
Implements functionality for bypassing taker fee via whitelist.
The whitelist is to be controlled by governance. It is expected that stakeholders that meet certain governance-defined qualifications, may bypass the taker fee.
This is useful for client protocols that rely on frequent rebalancing via swaps.
Testing and Verifying
chargeTakerFee
method that returns thetokenIn
without taker fee charged if the sender is in the whitelistDocumentation and Release Note
Unreleased
section ofCHANGELOG.md
?Where is the change documented?
x/{module}/README.md
)