Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add auth.moduleaccounts to the stargate whitelist #6586

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

ibjc
Copy link
Contributor

@ibjc ibjc commented Sep 28, 2023

Closes: #6585

What is the purpose of the change

this PR will enable smart contracts to fetch osmosis's module accounts.

Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

  • that said, let us know if this code change is not considered trivial *

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • [ x] N/A

@mattverse
Copy link
Member

devbot help

@devbot-wizard
Copy link
Collaborator

Hi! I'm DevBot, a bot that helps with common tasks in the development process. Commands:

  • devbot fix: Fix basic errors in the PR. (e.g. imports, changelog conflicts, go mod conflicts)
  • devbot merge base: Merge the base branch into the PR branch.
  • devbot add changelog [misc/feat/bug/api/sec] [message]: Add a changelog entry to the PR. (e.g. devbot add changelog feat Added a new feature)
    • If message is blank, defaults to PR title.
  • devbot re-pr: Re-PR the PR, useful for external contributors where we have no edit perms.

@mattverse mattverse added the V:state/breaking State machine breaking PR label Sep 29, 2023
Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This query already present in osmosis std, lgtm

@mattverse
Copy link
Member

@ibjc Would you be able to add a changelog for this? Thanks!

@ibjc
Copy link
Contributor Author

ibjc commented Sep 29, 2023

@ibjc Would you be able to add a changelog for this? Thanks!

oh sure thing, will do

@mattverse mattverse merged commit 9223007 into osmosis-labs:main Oct 5, 2023
1 check passed
pysel pushed a commit that referenced this pull request Oct 5, 2023
* add auth.moduleaccounts to the stargate whitelist

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V:state/breaking State machine breaking PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Add QueryModuleAccounts from x/auth to stargate whitelist
3 participants