Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(osmoutils): remove redundant ctx param from DeleteAllKeysFromPrefix #6510

Merged
merged 4 commits into from
Sep 24, 2023
Merged

refactor(osmoutils): remove redundant ctx param from DeleteAllKeysFromPrefix #6510

merged 4 commits into from
Sep 24, 2023

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Sep 23, 2023

Closes: #XXX

What is the purpose of the change

Removes redundant param

@github-actions github-actions bot added the C:x/gamm Changes, features and bugs related to the gamm module. label Sep 23, 2023
@p0mvn
Copy link
Member Author

p0mvn commented Sep 23, 2023

@devbot-wizard help

@devbot-wizard
Copy link
Collaborator

Hi! I'm DevBot, a bot that helps with common tasks in the development process. Commands:

  • devbot fix: Fix basic errors in the PR. (e.g. imports, changelog conflicts, go mod conflicts)
  • devbot merge base: Merge the base branch into the PR branch.
  • devbot add changelog [misc/feat/bug/api/sec] [message]: Add a changelog entry to the PR. (e.g. devbot add changelog feat Added a new feature)
    • If message is blank, defaults to PR title.
  • devbot re-pr: Re-PR the PR, useful for external contributors where we have no edit perms.

@github-actions
Copy link
Contributor

Important Notice

This PR modifies an in-repo Go module. It is one of:

  • osmomath
  • osmoutils
  • x/ibc-hooks
  • x/epochs

The dependent Go modules, especially the root one, will have to be
updated to reflect the changes. Failing to do so might cause e2e to fail.

Please follow the instructions below:

  1. Open https://github.com/osmosis-labs/osmosis/actions/workflows/go-mod-auto-bump.yml
  2. Provide the current branch name
  3. On success, confirm if an automated commit corretly updated the go.mod and go.sum files

Please let us know if you need any help.

@p0mvn
Copy link
Member Author

p0mvn commented Sep 23, 2023

@devbot-wizard add changelog api remove redundant ctx param from DeleteAllKeysFromPrefix in osmoutils

@p0mvn p0mvn added the V:state/compatible/backport State machine compatible PR, should be backported label Sep 23, 2023
@p0mvn p0mvn added the A:backport/v19.x backport patches to v19.x branch label Sep 23, 2023
@p0mvn p0mvn closed this Sep 23, 2023
@p0mvn p0mvn reopened this Sep 23, 2023
@p0mvn p0mvn marked this pull request as ready for review September 23, 2023 22:42
AlpinYukseloglu
AlpinYukseloglu approved these changes Sep 23, 2023
View reviewed changes
Copy link
Contributor

@AlpinYukseloglu AlpinYukseloglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm interesting that this made it in - I don't see any documentation explaining why this might have been intentional so presumably it's good to remove. Implementation LGTM

@p0mvn p0mvn merged commit 540c8c9 into main Sep 24, 2023
1 check passed
@p0mvn p0mvn deleted the roman/remove-param branch September 24, 2023 03:21
mergify bot pushed a commit that referenced this pull request Sep 24, 2023
@p0mvn @mergify
refactor(osmoutils): remove redundant ctx param from DeleteAllKeysFro…
444450a 
…mPrefix (#6510)

* refactor(osmoutils): remove redundant ctx param from DeleteAllKeysFromPrefix

* update changelog

* Auto: update go.mod after push to roman/remove-param that modified dependencies locally

* updates

---------

Co-authored-by: devbot-wizard <[email protected]>
Co-authored-by: github-actions <[email protected]>
(cherry picked from commit 540c8c9)

# Conflicts:
#	go.mod
#	go.sum
#	osmoutils/go.sum
#	tests/cl-genesis-positions/go.mod
#	tests/cl-genesis-positions/go.sum
#	tests/cl-go-client/go.mod
#	tests/cl-go-client/go.sum
#	x/epochs/go.mod
#	x/epochs/go.sum
#	x/ibc-hooks/go.mod
#	x/ibc-hooks/go.sum
@mergify mergify bot mentioned this pull request Sep 24, 2023
Merged
@nicolaslara
Copy link
Contributor

👏

p0mvn added a commit that referenced this pull request Sep 26, 2023
@p0mvn
refactor(osmoutils): remove redundant ctx param from DeleteAllKeysFro…
a9f2936 
…mPrefix (backport #6510)
p0mvn added a commit that referenced this pull request Sep 26, 2023
@mergify @p0mvn
refactor(osmoutils): remove redundant ctx param from DeleteAllKeysFro…
cbd8079 
…mPrefix (backport #6510) (#6514)

* refactor(osmoutils): remove redundant ctx param from DeleteAllKeysFromPrefix (backport #6510)

* updates

---------

Co-authored-by: roman <[email protected]>
@github-actions github-actions bot mentioned this pull request Feb 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlpinYukseloglu AlpinYukseloglu AlpinYukseloglu approved these changes

@mattverse mattverse Awaiting requested review from mattverse mattverse is a code owner

@czarcas7ic czarcas7ic Awaiting requested review from czarcas7ic czarcas7ic is a code owner

@nicolaslara nicolaslara Awaiting requested review from nicolaslara nicolaslara is a code owner

Assignees
No one assigned
Labels
A:backport/v19.x backport patches to v19.x branch C:x/epochs C:x/gamm Changes, features and bugs related to the gamm module. V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@p0mvn @devbot-wizard @nicolaslara @AlpinYukseloglu