refactor: state-breaking BigDec spot price changes and stargate whitelist #6490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:x/gamm
p0mvn
added
V:state/breaking
github-actions
bot
added
C:x/gamm
p0mvn
commented
Sep 21, 2023
Comment on lines
-86
to
+92
| return osmomath.MustNewBigDecFromStr(response.SpotPrice), nil | ||
|
|
||
| result, err := osmomath.NewBigDecFromStr(response.SpotPrice) | ||
| if err != nil { | ||
| return osmomath.BigDec{}, err | ||
| } | ||
|
|
||
| return result, nil |
There was a problem hiding this comment.
Note: This is a precaution and a follow-up to a review discussion.
Ref: #6406
p0mvn
commented
Sep 22, 2023
p0mvn
force-pushed
the
roman/bigdec-sp
branch
from
a2180c4 to
1dcdd1a
Compare
github-actions
bot
added
C:CLI
C:app-wiring
p0mvn
commented
Sep 22, 2023
| return q.Q.{{.QueryName}}(ctx, *req) | ||
| return q.Q.{{.QueryName}}{{ $version | ToUpper }}(ctx, *req) |
There was a problem hiding this comment.
Note: this is needed to avoid conflicts and name clashes with v1
p0mvn
force-pushed
the
roman/bigdec-sp
branch
from
1dcdd1a to
002d139
Compare
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #6064, #6406
What is the purpose of the change
State-breaking changes to enable 36 decimal spot price query. Includes stargate whitelist for the new query.
Addresses all TODOs in the linked issue.
There is some diff that stems from template code-generation empty lines.
Testing and Verifying
Documentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)