feat: make PoolModuleI CalculateSpotPrice API return BigDec #6487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:CLI
C:x/gamm
p0mvn
added
V:state/compatible/backport
p0mvn
commented
Sep 21, 2023
Comment on lines
+282
to
+284
| // TODO: remove Dec truncation before https://github.com/osmosis-labs/osmosis/issues/5726 is complete | ||
| // Currently exists for state-compatibility with v19.x | ||
| s.Require().Equal(spotPriceBaseETH.Dec(), DefaultCurrSqrtPrice.PowerInteger(2).Dec()) |
p0mvn
commented
Sep 21, 2023
Comment on lines
+289
to
+291
| // TODO: remove Dec truncation before https://github.com/osmosis-labs/osmosis/issues/5726 is complete | ||
| // Currently exists for state-compatibility with v19.x | ||
| s.Require().Equal(spotPriceBaseUSDC.Dec(), osmomath.OneBigDec().Quo(DefaultCurrSqrtPrice.PowerInteger(2)).Dec()) |
p0mvn
commented
Sep 21, 2023
Comment on lines
+48
to
+50
| // TODO: this is done to maintain state-compatibility with v19.x | ||
| // Remove after https://github.com/osmosis-labs/osmosis/issues/6064 is complete. | ||
| spotPrice.ChopPrecisionMut(osmomath.PrecisionDec) |
p0mvn
commented
Sep 21, 2023
Comment on lines
+54
to
+55
| // TODO: remove truncation before https://github.com/osmosis-labs/osmosis/issues/6064 is fully complete. | ||
| return &types.QueryDenomSpotPriceResponse{PoolID: feeToken.PoolID, SpotPrice: spotPrice.Dec()}, nil |
p0mvn
commented
Sep 21, 2023
Comment on lines
+35
to
+38
| // Note: spotPrice truncation is done here for maintaining state-compatibility with v19.x | ||
| // It should be changed to support full spot price precision before | ||
| // https://github.com/osmosis-labs/osmosis/issues/6064 is complete | ||
| return sdk.NewCoin(baseDenom, spotPrice.Dec().MulInt(inputFee.Amount).RoundInt()), nil |
p0mvn
requested review from
nicolaslara,
AlpinYukseloglu,
czarcas7ic and
mattverse
as code owners
mattverse
approved these changes
Sep 22, 2023
|
Merging with one approval since this is a low-risk change that will be backported to v19.x and tested for state-compat |
mergify bot
pushed a commit
that referenced
this pull request
Sep 22, 2023
* feat: make PoolModuleI CalculateSpotPrice API return BigDec * updates * clean up * updates * updates (cherry picked from commit a171707) # Conflicts: # CHANGELOG.md # app/upgrades/v16/upgrades_test.go # app/upgrades/v17/upgrades_test.go # x/poolmanager/router.go
p0mvn
added a commit
that referenced
this pull request
Sep 22, 2023
p0mvn
added a commit
that referenced
this pull request
Sep 22, 2023
…6487) (#6495) Co-authored-by: roman <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress towards: #6064
What is the purpose of the change
This PR aims to continue the progress toward introducing a BigDec spot price query.
It should be state-compatible. The current clients are not expected to be broken because we truncate the spot price to 18 decimals before returning.
In the subsequent PR, a new spot price query is to be introduced that returns a 36-decimal spot price.
Testing and Verifying
Documentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)