-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove osmo multihop discount #6468
Conversation
devbot help |
Hi! I'm DevBot, a bot that helps with common tasks in the development process. Commands:
|
devbot add changelog feat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice work!
@czarcas7ic Do you think it makes sense to have a single test case with Base Denom: showing that base denom does not account for multihop doscount before having this merged?
@mattverse I had kept two tests from the previous feat that had accounted for multihop discount which no longer show a discount. Are those sufficient are you are saying there should be more? |
* remove osmo multihop discount * update changelog * edit comments * add sanity check that reduced swap fee is no longer applied --------- Co-authored-by: devbot-wizard <[email protected]> Co-authored-by: Matt, Park <[email protected]>
Closes: #6373
What is the purpose of the change
Actions remaining part of prop 530
Taker fees are already implemented. We just need to remove the multi-hop discount
Testing and Verifying
Much of this PR is removing the specific osmo multi-hop discount logic/tests.
Kept some osmo incentivized multi hop pools in the tests to ensure the discount is no longer applied.
Documentation and Release Note
Unreleased
section ofCHANGELOG.md
?Where is the change documented?
x/{module}/README.md
)