Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(gamm/CL): backport more QuoRoundUp optimizations from v19.x #6462

Merged
merged 2 commits into from
Sep 20, 2023
Merged

perf(gamm/CL): backport more QuoRoundUp optimizations from v19.x #6462

merged 2 commits into from
Sep 20, 2023

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Sep 20, 2023

Closes: #XXX

What is the purpose of the change

QuoRoundUpMut on BigDec was introduced:
#6437

In the backport, we applied more state-compatible changes: #6458

This PR backports these optimizations to main

Testing and Verifying

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

@p0mvn p0mvn added V:state/compatible/no_backport State machine compatible PR, depends on prior breaks A:no-changelog labels Sep 20, 2023
@github-actions github-actions bot added C:x/gamm Changes, features and bugs related to the gamm module. C:x/concentrated-liquidity labels Sep 20, 2023
@p0mvn
Copy link
Member Author

p0mvn commented Sep 20, 2023 •
edited
Loading

No changelog and no backport label because this was already backported via #6458

@p0mvn p0mvn marked this pull request as ready for review September 20, 2023 18:15
czarcas7ic
czarcas7ic approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@czarcas7ic czarcas7ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, thanks

@p0mvn p0mvn merged commit 17569b1 into main Sep 20, 2023
1 check passed
@p0mvn p0mvn deleted the roman/backport-opts branch September 20, 2023 18:20
@ValarDragon
Copy link
Member

Nice, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czarcas7ic czarcas7ic czarcas7ic approved these changes

@mattverse mattverse Awaiting requested review from mattverse mattverse is a code owner

@AlpinYukseloglu AlpinYukseloglu Awaiting requested review from AlpinYukseloglu AlpinYukseloglu is a code owner

Assignees
No one assigned
Labels
A:no-changelog C:x/concentrated-liquidity C:x/gamm Changes, features and bugs related to the gamm module. V:state/compatible/no_backport State machine compatible PR, depends on prior breaks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@p0mvn @ValarDragon @czarcas7ic