-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(osmoutils): coin math helpers #6427
Conversation
Important Notice This PR modifies an in-repo Go module. It is one of:
The dependent Go modules, especially the root one, will have to be Please follow the instructions below:
Please let us know if you need any help. |
Merging with one ACK since helpers are simple and the majority of the diff is stemming from code duplication of similar helpers |
* feat(osmoutils): coin math helpers * updates * go mod (cherry picked from commit d00cb3e) # Conflicts: # CHANGELOG.md # go.mod # go.sum
* feat(osmoutils): coin math helpers (backport #6427) * go mod * updates --------- Co-authored-by: roman <[email protected]>
Closes: #XXX
What is the purpose of the change
Reimplemented the same functionality 3 times while working on volume splitting.
Realized that upstream SDK supports a subset of these but not all.
I think it still makes sense to have them in our osmoutils for the speed of iteration and exhaustive support
Testing and Verifying
Documentation and Release Note
Unreleased
section ofCHANGELOG.md
?Where is the change documented?
x/{module}/README.md
)