bypass permissionless concentrated liquidity checks #6420

sunnya97 · 2023-09-16T17:40:51Z

Closes: #6345

Creates a governance set whitelist of addresses that can bypass the normal pool creation restrictions on concentrated liquidity pools

What is the purpose of the change

Allow a governance subdao automatically approved stAsset/Asset pools for non-approved quote assets.
Allow a governance subdao to create pools when permissionless pool creation is off

Testing and Verifying

Added unit tests

Documentation and Release Note

Does this pull request introduce a new feature or user-facing behavior changes?
Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

Specification (x/{module}/README.md)
Osmosis documentation site
Code comments?
N/A

p0mvn

LGTM once CI is happy!

Need to add a changelog entry for everything to pass

p0mvn · 2023-09-17T21:08:44Z

x/concentrated-liquidity/pool_test.go

+				fmt.Println("setting")
+				fmt.Println(params.UnrestrictedPoolCreatorWhitelist)
+				s.App.ConcentratedLiquidityKeeper.SetParams(s.Ctx, params)
+				fmt.Println("getting")
+				fmt.Println(s.App.ConcentratedLiquidityKeeper.GetParams(s.Ctx).UnrestrictedPoolCreatorWhitelist)


nit: prints but I saw them being removed in a follow-up PR so good with keeping them until then

mattverse

Implementation straight forward and lgtm for me as well, I'm wondering why e2e is failing, Im wondering if it could be the new param that we are adding, might need to handle it in upgrades.go?

x/concentrated-liquidity/pool_test.go

.github/dependabot.yml

CHANGELOG.md

sunnya97 · 2023-09-19T15:37:13Z

I'm not sure why my e2e is failing ☹️

This reverts commit 8779a3d.

p0mvn · 2023-09-19T18:17:51Z

I'm not sure why my e2e is failing ☹️

There was an issue on main. Got fixed yesterday by: #6426

Merging main here might help

github-actions · 2023-09-20T16:54:34Z

Important Notice

This PR modifies an in-repo Go module. It is one of:

osmomath
osmoutils
x/ibc-hooks
x/epochs

The dependent Go modules, especially the root one, will have to be
updated to reflect the changes. Failing to do so might cause e2e to fail.

Please follow the instructions below:

Open https://github.com/osmosis-labs/osmosis/actions/workflows/go-mod-auto-bump.yml
Provide the current branch name
On success, confirm if an automated commit corretly updated the go.mod and go.sum files

Please let us know if you need any help.

…ed dependencies locally

czarcas7ic · 2023-09-20T17:24:36Z

Re-requesting reviews since I added logic on top of this, but logic that is required to properly initialize new params for this PR and future PRs.

0441ca3

p0mvn · 2023-09-20T17:37:18Z

app/upgrades/v20/upgrades.go

+		// Initialize the newly created param
+		keepers.ConcentratedLiquidityKeeper.SetParam(ctx, cltypes.KeyUnrestrictedPoolCreatorWhitelist, []string{})


This feels like something that the upstream SDK should automate. WDYT about opening up an issue?

I will open up an issue rn and link it here, good idea

Created cosmos/cosmos-sdk#17826 (comment)

p0mvn

e2e fix makes sense to me! Nice work @czarcas7ic and @sunnya97

sunnya97 · 2023-09-21T02:42:26Z

Ah yes, this makes sense

mattverse

Nice work on the investigation @czarcas7ic ! 🎊

IMO we should have an API for this upstream where we can pass in the param we are adding and then rest is taken care of in sdk

czarcas7ic

Approved, merging, thanks all

in progress

17c7339

github-actions bot added the C:x/concentrated-liquidity label Sep 16, 2023

sunnya97 added 2 commits September 17, 2023 13:48

fix params setting

c249317

add param to newParams function

c59a191

sunnya97 added the V:state/breaking State machine breaking PR label Sep 17, 2023

sunnya97 marked this pull request as ready for review September 17, 2023 16:02

sunnya97 requested review from czarcas7ic, p0mvn and AlpinYukseloglu as code owners September 17, 2023 16:02

sunnya97 mentioned this pull request Sep 17, 2023

Moves ValidatePermissionlessPoolCreationEnabled out of poolmanager module #6421

Merged

6 tasks

p0mvn approved these changes Sep 17, 2023

View reviewed changes

mattverse approved these changes Sep 18, 2023

View reviewed changes

sunnya97 commented Sep 18, 2023

View reviewed changes

x/concentrated-liquidity/pool_test.go Outdated Show resolved Hide resolved

sunnya97 commented Sep 18, 2023

View reviewed changes

x/concentrated-liquidity/pool_test.go Outdated Show resolved Hide resolved

sunnya97 and others added 2 commits September 18, 2023 21:28

Apply suggestions from code review

f402dcf

changelog

0527c9b

sunnya97 requested a review from a team as a code owner September 18, 2023 13:20

github-actions bot added T:CI C:app-wiring Changes to the app folder labels Sep 18, 2023

sunnya97 commented Sep 18, 2023

View reviewed changes

.github/dependabot.yml Outdated Show resolved Hide resolved

sunnya97 commented Sep 18, 2023

View reviewed changes

.github/dependabot.yml Outdated Show resolved Hide resolved

sunnya97 commented Sep 18, 2023

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

github-actions bot removed the T:CI label Sep 18, 2023

sunnya97 force-pushed the sunny/bypass-cl-checks- branch from e17cfb8 to 0527c9b Compare September 18, 2023 14:07

github-actions bot removed the C:app-wiring Changes to the app folder label Sep 18, 2023

sunnya97 added 2 commits September 20, 2023 00:56

updated proto

8779a3d

Revert "updated proto"

95974b2

This reverts commit 8779a3d.

Merge branch 'main' into sunny/bypass-cl-checks-

e8f4849

github-actions bot added C:x/lockup C:x/gamm Changes, features and bugs related to the gamm module. C:x/mint C:x/incentives C:x/pool-incentives C:x/superfluid C:x/tokenfactory C:x/twap Changes to the twap module C:x/poolmanager labels Sep 20, 2023

github-actions and others added 2 commits September 20, 2023 17:12

Auto: update go.mod after push to sunny/bypass-cl-checks- that modifi…

6d2c85a

…ed dependencies locally

go sum update

0656566

github-actions bot added the C:x/epochs label Sep 20, 2023

czarcas7ic added 2 commits September 20, 2023 11:16

Merge branch 'main' into sunny/bypass-cl-checks-

b1f6114

go sum update

5426164

czarcas7ic requested review from p0mvn and mattverse September 20, 2023 17:24

p0mvn reviewed Sep 20, 2023

View reviewed changes

p0mvn approved these changes Sep 20, 2023

View reviewed changes

sunnya97 and others added 2 commits September 21, 2023 11:50

Merge branch 'main' into sunny/bypass-cl-checks-

b231906

go mod tidy

929ef2b

mattverse approved these changes Sep 21, 2023

View reviewed changes

czarcas7ic approved these changes Sep 21, 2023

View reviewed changes

czarcas7ic merged commit b7c73fb into main Sep 21, 2023
1 check passed

czarcas7ic deleted the sunny/bypass-cl-checks- branch September 21, 2023 15:26

JohnnyWyles mentioned this pull request Jan 18, 2024

Exempt addresses on UnrestrictedPoolCreatorWhitelist from pool creation fees #7337

Closed

github-actions bot mentioned this pull request May 15, 2024

Broken Links Detected #8269

Closed

github-actions bot mentioned this pull request Oct 15, 2024

Broken Links Detected notional-labs/osmosis#75

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bypass permissionless concentrated liquidity checks #6420

bypass permissionless concentrated liquidity checks #6420

sunnya97 commented Sep 16, 2023 •

edited by czarcas7ic

Loading

p0mvn left a comment

p0mvn Sep 17, 2023

mattverse left a comment

sunnya97 commented Sep 19, 2023

p0mvn commented Sep 19, 2023

github-actions bot commented Sep 20, 2023 •

edited

Loading

czarcas7ic commented Sep 20, 2023

p0mvn Sep 20, 2023

czarcas7ic Sep 20, 2023

czarcas7ic Sep 20, 2023

p0mvn left a comment

sunnya97 commented Sep 21, 2023

mattverse left a comment

czarcas7ic left a comment

		// Initialize the newly created param
		keepers.ConcentratedLiquidityKeeper.SetParam(ctx, cltypes.KeyUnrestrictedPoolCreatorWhitelist, []string{})

bypass permissionless concentrated liquidity checks #6420

bypass permissionless concentrated liquidity checks #6420

Conversation

sunnya97 commented Sep 16, 2023 • edited by czarcas7ic Loading

What is the purpose of the change

Testing and Verifying

Documentation and Release Note

p0mvn left a comment

Choose a reason for hiding this comment

p0mvn Sep 17, 2023

Choose a reason for hiding this comment

mattverse left a comment

Choose a reason for hiding this comment

sunnya97 commented Sep 19, 2023

p0mvn commented Sep 19, 2023

github-actions bot commented Sep 20, 2023 • edited Loading

czarcas7ic commented Sep 20, 2023

p0mvn Sep 20, 2023

Choose a reason for hiding this comment

czarcas7ic Sep 20, 2023

Choose a reason for hiding this comment

czarcas7ic Sep 20, 2023

Choose a reason for hiding this comment

p0mvn left a comment

Choose a reason for hiding this comment

sunnya97 commented Sep 21, 2023

mattverse left a comment

Choose a reason for hiding this comment

czarcas7ic left a comment

Choose a reason for hiding this comment

sunnya97 commented Sep 16, 2023 •

edited by czarcas7ic

Loading

github-actions bot commented Sep 20, 2023 •

edited

Loading