feat[CL]: add num initialized ticks query #6416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czarcas7ic
added
V:state/compatible/backport
|
devbot help |
|
Hi! I'm DevBot, a bot that helps with common tasks in the development process. Commands:
|
|
devbot add changelog feat |
p0mvn
approved these changes
Sep 15, 2023
|
|
||
| liquidityDepths := []queryproto.TickLiquidityNet{} | ||
|
|
||
| iterationCount := uint64(0) |
There was a problem hiding this comment.
Yes, iterationCount refers to the user provided literation limit
There was a problem hiding this comment.
Ah right, mistook this for the Go-side limit we discussed before
mergify bot
pushed a commit
that referenced
this pull request
Sep 15, 2023
* add num initialized ticks query * update changelog * Generated protofile changes * add max number of initialized ticks to return * Generated protofile changes * remove limit * update query.yml * add go test --------- Co-authored-by: devbot-wizard <[email protected]> Co-authored-by: github-actions <[email protected]> (cherry picked from commit 9f664d7) # Conflicts: # CHANGELOG.md # x/concentrated-liquidity/client/queryproto/query.pb.go
czarcas7ic
added a commit
that referenced
this pull request
Sep 15, 2023
* feat[CL]: add num initialized ticks query (#6416) * add num initialized ticks query * update changelog * Generated protofile changes * add max number of initialized ticks to return * Generated protofile changes * remove limit * update query.yml * add go test --------- Co-authored-by: devbot-wizard <[email protected]> Co-authored-by: github-actions <[email protected]> (cherry picked from commit 9f664d7) # Conflicts: # CHANGELOG.md # x/concentrated-liquidity/client/queryproto/query.pb.go * Generated protofile changes * Update CHANGELOG.md * fix merge conflicts --------- Co-authored-by: Adam Tucker <[email protected]> Co-authored-by: github-actions <[email protected]> Co-authored-by: Adam Tucker <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
We currently have a LiquidityNetInDirection query, which allows us to provide a start and end tick, traverse this range, and return the liquidity net. The unknown here is how many initialized ticks actually exist in this range.
For purposes of understanding the impact a swap will have on the current sqrt price, it's helpful to request the next X initialized ticks and return their liquidity depths, regaurdless of how many ticks need to be traversed to get to X.
Testing and Verifying
TBD
Documentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)