Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedup Fractional exponentiation, and make a benchmark #6392

Merged
merged 4 commits into from
Sep 20, 2023

Conversation

ValarDragon
Copy link
Member

cref @samalws-tob

This state compatibly speeds up the Fractional exponentiation core loop by approximately 10%. Will look for more speed ups (the mul and quo should be state compatibly speedup)

@github-actions
Copy link
Contributor

Important Notice

This PR modifies an in-repo Go module. It is one of:

  • osmomath
  • osmoutils
  • x/ibc-hooks
  • x/epochs

The dependent Go modules, especially the root one, will have to be
updated to reflect the changes. Failing to do so might cause e2e to fail.

Please follow the instructions below:

  1. Open https://github.com/osmosis/osmosis/actions/workflows/go-mod-auto-bump.yml
  2. Provide the current branch name
  3. On success, confirm if an automated commit corretly updated the go.mod and go.sum files

Please let us know if you need any help.

@ValarDragon ValarDragon marked this pull request as draft September 13, 2023 14:29
@ValarDragon ValarDragon added the V:state/compatible/backport State machine compatible PR, should be backported label Sep 14, 2023
@ValarDragon
Copy link
Member Author

devbot add changelog perf

@ValarDragon ValarDragon marked this pull request as ready for review September 19, 2023 15:16
Copy link
Member

@p0mvn p0mvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Going to backport and test for state-compatibility on v19.x

@p0mvn p0mvn added the A:backport/v19.x backport patches to v19.x branch label Sep 20, 2023
@p0mvn p0mvn merged commit c54e222 into main Sep 20, 2023
1 check passed
@p0mvn p0mvn deleted the dev/speedup_frac_exp branch September 20, 2023 18:00
mergify bot pushed a commit that referenced this pull request Sep 20, 2023
* Speedup Fractional exponentiation, and make a benchmark

* update changelog

---------

Co-authored-by: devbot-wizard <[email protected]>
(cherry picked from commit c54e222)

# Conflicts:
#	CHANGELOG.md
p0mvn added a commit that referenced this pull request Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v19.x backport patches to v19.x branch V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants