Make cosmwasmpool's create pool cli generic #6388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iboss-ptk
requested review from
p0mvn,
mattverse and
AlpinYukseloglu
and removed request for
mattverse
iboss-ptk
added
the
V:state/compatible/no_backport
p0mvn
approved these changes
Sep 13, 2023
p0mvn
added
V:state/compatible/backport
mergify bot
pushed a commit
that referenced
this pull request
Sep 20, 2023
* make create pool generic * update changelog (cherry picked from commit ebb31b6)
p0mvn
pushed a commit
that referenced
this pull request
Sep 20, 2023
* make create pool generic * update changelog (cherry picked from commit ebb31b6) Co-authored-by: Supanat <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The previous
create-poolcommand expect contract's instantiate msg to have certain structure which might not be the case for every cosmwasmpool. So this update is to allow passing instantiate msg raw json string directly to the cli.Testing and Verifying
Manually verify change by running the command
Documentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)