Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable taker fee cli #6334

Merged
merged 2 commits into from
Sep 7, 2023
Merged

fix: enable taker fee cli #6334

merged 2 commits into from
Sep 7, 2023

Conversation

czarcas7ic
Copy link
Member

Closes: #XXX

What is the purpose of the change

The "denom pair taker fee" prop CLI was not enabled. Also, the CLI that the DAO contract can use to set denom pairs was also not activated. This does both.

Testing and Verifying

Locally installed and now see the CLI entry.

@czarcas7ic czarcas7ic added the A:backport/v19.x backport patches to v19.x branch label Sep 7, 2023
@github-actions github-actions bot added C:CLI C:app-wiring Changes to the app folder C:x/poolmanager labels Sep 7, 2023
@czarcas7ic
Copy link
Member Author

devbot help

@devbot-wizard
Copy link
Collaborator

Hi! I'm DevBot, a bot that helps with common tasks in the development process. Commands:

  • devbot fix: Fix basic errors in the PR. (e.g. imports, changelog conflicts, go mod conflicts)
  • devbot merge base: Merge the base branch into the PR branch.
  • devbot add changelog [misc/feat/bug/api/sec] [message]: Add a changelog entry to the PR. (e.g. devbot add changelog feat Added a new feature)
    • If message is blank, defaults to PR title.
  • devbot re-pr: Re-PR the PR, useful for external contributors where we have no edit perms.

@czarcas7ic
Copy link
Member Author

devbot add changelog bug

@czarcas7ic czarcas7ic added the V:state/compatible/backport State machine compatible PR, should be backported label Sep 7, 2023
@czarcas7ic czarcas7ic marked this pull request as ready for review September 7, 2023 14:39
@czarcas7ic czarcas7ic merged commit ea83071 into main Sep 7, 2023
@czarcas7ic czarcas7ic deleted the adam/taker-fee-cli branch September 7, 2023 15:23
mergify bot pushed a commit that referenced this pull request Sep 7, 2023
@czarcas7ic @mergify
fix: enable taker fee cli (#6334)
a808ae7 
* enable prop cli

* update changelog

---------

Co-authored-by: devbot-wizard <[email protected]>
(cherry picked from commit ea83071)
@mergify mergify bot mentioned this pull request Sep 7, 2023
Merged
czarcas7ic added a commit that referenced this pull request Sep 7, 2023
@mergify @czarcas7ic
fix: enable taker fee cli (#6334) (#6335)
6efdff2 
* enable prop cli

* update changelog

---------

Co-authored-by: devbot-wizard <[email protected]>
(cherry picked from commit ea83071)

Co-authored-by: Adam Tucker <[email protected]>
@github-actions github-actions bot mentioned this pull request Feb 15, 2024
Closed
@github-actions github-actions bot mentioned this pull request May 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p0mvn p0mvn p0mvn approved these changes

@mattverse mattverse Awaiting requested review from mattverse mattverse is a code owner

@AlpinYukseloglu AlpinYukseloglu Awaiting requested review from AlpinYukseloglu AlpinYukseloglu is a code owner

Assignees
No one assigned
Labels
A:backport/v19.x backport patches to v19.x branch C:app-wiring Changes to the app folder C:CLI C:x/poolmanager V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@czarcas7ic @devbot-wizard @p0mvn