Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CreateCanonicalConcentratedLiquidityPoolAndMigrationLink overriding migration records #6282

Merged
merged 5 commits into from
Sep 14, 2023
Merged

Fix CreateCanonicalConcentratedLiquidityPoolAndMigrationLink overriding migration records #6282

merged 5 commits into from
Sep 14, 2023

Conversation

ValarDragon
Copy link
Member

Tests still need to be added to this PR.

@ValarDragon ValarDragon added the V:state/breaking State machine breaking PR label Sep 2, 2023
@ValarDragon
Copy link
Member Author

devbot add changelog breaking

@github-actions github-actions bot added the C:x/gamm Changes, features and bugs related to the gamm module. label Sep 2, 2023
czarcas7ic
czarcas7ic approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@czarcas7ic czarcas7ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added test which passes. Reverted the change with the passing test in place and it failed. Merging after CI passes.

@czarcas7ic czarcas7ic merged commit eb14ab8 into main Sep 14, 2023
1 check passed
@czarcas7ic czarcas7ic deleted the dev/fix_CreateCanonicalConcentratedLiquidityPoolAndMigrationLink_big branch September 14, 2023 19:35
@github-actions github-actions bot mentioned this pull request Apr 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czarcas7ic czarcas7ic czarcas7ic approved these changes

@mattverse mattverse Awaiting requested review from mattverse mattverse is a code owner

@p0mvn p0mvn Awaiting requested review from p0mvn p0mvn is a code owner

@AlpinYukseloglu AlpinYukseloglu Awaiting requested review from AlpinYukseloglu AlpinYukseloglu is a code owner

Assignees
No one assigned
Labels
C:x/gamm Changes, features and bugs related to the gamm module. V:state/breaking State machine breaking PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ValarDragon @czarcas7ic @devbot-wizard