Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fix for prop 597 code issue #6279

Merged
merged 4 commits into from
Sep 2, 2023
Merged

Conversation

ValarDragon
Copy link
Member

@ValarDragon ValarDragon commented Sep 2, 2023

Proposal 597 broke the cfmm-gamm pool links, due to the governance logic not behaving as expected (replacing a list of instead of fixing it)

Proposed for this to be included in the v19 upgrade due to urgency at hand.

@ValarDragon ValarDragon added the A:backport/v19.x backport patches to v19.x branch label Sep 2, 2023
@github-actions github-actions bot added the C:app-wiring Changes to the app folder label Sep 2, 2023
@ValarDragon ValarDragon added the V:state/breaking State machine breaking PR label Sep 2, 2023
@ValarDragon
Copy link
Member Author

devbot add changelog fix prop-572 introduced issue

@p0mvn p0mvn changed the title Add fix for prop 572 code issue Add fix for prop 597 code issue Sep 2, 2023
Copy link
Member

@p0mvn p0mvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated that all pool IDs from linked proposals are present

Corrected the prop id that broke it to 597

CHANGELOG.md Outdated Show resolved Hide resolved
app/upgrades/v19/constants.go Show resolved Hide resolved
app/upgrades/v19/constants.go Show resolved Hide resolved
app/upgrades/v19/constants.go Show resolved Hide resolved
@p0mvn
Copy link
Member

p0mvn commented Sep 2, 2023

e2e is failing because init genesis is not updated accordingly.

Started to update it in: #6280

However, I think we should merge as is and instead just test on a state-exported testnet

@ValarDragon ValarDragon merged commit bd09d44 into main Sep 2, 2023
@ValarDragon ValarDragon deleted the dev/fix_prop_572_code_issue branch September 2, 2023 23:22
mergify bot pushed a commit that referenced this pull request Sep 2, 2023
* Add fix for prop 572 code issue

* update changelog

* Update CHANGELOG.md

* basic upgrade unit test

---------

Co-authored-by: devbot-wizard <[email protected]>
Co-authored-by: Roman <[email protected]>
(cherry picked from commit bd09d44)

# Conflicts:
#	CHANGELOG.md
#	app/upgrades/v19/upgrades_test.go
ValarDragon added a commit that referenced this pull request Sep 2, 2023
ValarDragon added a commit that referenced this pull request Sep 3, 2023
pysel pushed a commit that referenced this pull request Sep 4, 2023
* Add fix for prop 572 code issue

* update changelog

* Update CHANGELOG.md

* basic upgrade unit test

---------

Co-authored-by: devbot-wizard <[email protected]>
Co-authored-by: Roman <[email protected]>
pysel pushed a commit that referenced this pull request Sep 4, 2023
pysel pushed a commit that referenced this pull request Sep 4, 2023
* Add fix for prop 572 code issue

* update changelog

* Update CHANGELOG.md

* basic upgrade unit test

---------

Co-authored-by: devbot-wizard <[email protected]>
Co-authored-by: Roman <[email protected]>
pysel pushed a commit that referenced this pull request Sep 4, 2023
pysel pushed a commit that referenced this pull request Sep 4, 2023
* Add fix for prop 572 code issue

* update changelog

* Update CHANGELOG.md

* basic upgrade unit test

---------

Co-authored-by: devbot-wizard <[email protected]>
Co-authored-by: Roman <[email protected]>
pysel pushed a commit that referenced this pull request Sep 4, 2023
@github-actions github-actions bot mentioned this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v19.x backport patches to v19.x branch C:app-wiring Changes to the app folder V:state/breaking State machine breaking PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants