-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(spike): taker fee (backport #6034) #6212
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add taker fee determination and extraction * remove osmo multi hop logic * route to both community pool and staking rewards * fix a handfull of tests * assign taker fee to pool at time of creation * pull taker fee direct from pool struct * fix more tests * fix tests, set back up osmo multi hop discount * correct taker fee extraction * regen mocks * abstract taker fee to pool manager (highest lvl) * fix extract cmd * update changelog * tidy * remove param that no longer exists * add extra params to genesis logic * add back osmo multihop tests * add comment * fix e2e keeping prints * fixes * more test fixes * remove prints * more naive approach to determining taker fee * fix e2e * re-enable disabled test * minor cleaning * simplify params * not nullable * clean up * add whitelist set message denom pair taker fees * use real addresses * add gov prop for denom pair taker fee update * clean * move logic to its own taker_fee.go file * add CLI for gov prop for denomPairTakerFee * add admin address denomPairTakerFee cli msg * clean and simplifications * use authorized quote denoms from poolmanger * remove stableswap taker fee * sim msg change * add test for CLI * msg server tests * add route_test test * add gov_test.go * add msgs_test.go * remove print line * change from v18 to v19 * Update upgrades.go * set default taker fee to zero in upgrade handler * conflicts * Update proto/osmosis/poolmanager/v1beta1/genesis.proto * Update proto/osmosis/poolmanager/v1beta1/genesis.proto * Update x/poolmanager/taker_fee.go * Generated protofile changes * rename extractTakerFeeAndDistribute to chargeTakerFee * clean up * comment * rename * godoc for NonNativeFeeCollectorForCommunityPoolName * baseDenom to defaultFeesDenom name change * fix upgrade handler * fix AfterEpochEnd order of denoms when getting pools; reduce code dupl; tests * fix track volume * add key separator for pool manager * add comment to denom pair route * add basic lexicographical key test * update chargeTakerFee godoc * set the default taker fee back to non zero for e2e * change PoolMangerGetParams API to GetAuthorizedQuoteDenoms (same for setters) * update txfees & poolmanager READMEs with takerFee * fix merge main * add comment to denom pair taker fee * de-dup taker fee param validation * Update x/poolmanager/types/msgs.go * Apply suggestions from code review * Update x/poolmanager/taker_fee.go * remove unneeded setup test * get pool creation free from previous * take non native out of name * undo param pull instead of default * use current pool creation fee * use default * e2e --------- Co-authored-by: devbot-wizard <[email protected]> Co-authored-by: Roman <[email protected]> Co-authored-by: github-actions <[email protected]> Co-authored-by: alpo <[email protected]> Co-authored-by: Dev Ojha <[email protected]> Co-authored-by: Dev Ojha <[email protected]> (cherry picked from commit 5c8fd80) # Conflicts: # CHANGELOG.md # tests/e2e/e2e_test.go # x/poolmanager/export_test.go # x/poolmanager/router.go # x/poolmanager/types/keys.go
mergify
bot
requested review from
a team,
nicolaslara,
p0mvn,
AlpinYukseloglu and
mattverse
as code owners
August 28, 2023 17:13
github-actions
bot
added
C:docs
Improvements or additions to documentation
C:CLI
C:x/gamm
Changes, features and bugs related to the gamm module.
T:CI
C:x/superfluid
C:x/txfees
C:app-wiring
Changes to the app folder
C:simulator
Edits simulator or simulations
C:x/twap
Changes to the twap module
C:x/concentrated-liquidity
C:x/poolmanager
labels
Aug 28, 2023
ValarDragon
reviewed
Aug 28, 2023
czarcas7ic
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C:app-wiring
Changes to the app folder
C:CLI
C:docs
Improvements or additions to documentation
C:simulator
Edits simulator or simulations
C:x/concentrated-liquidity
C:x/gamm
Changes, features and bugs related to the gamm module.
C:x/poolmanager
C:x/superfluid
C:x/twap
Changes to the twap module
C:x/txfees
conflicts
T:CI
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #6034 done by Mergify.
Cherry-pick of 5c8fd80 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com