Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update app.go to correctly do module upgrade logic, add authz, IBC v2 #610

Merged
merged 5 commits into from
Nov 21, 2021

Conversation

ValarDragon
Copy link
Member

@ValarDragon ValarDragon commented Nov 21, 2021

Update app.go to correctly do SDK module upgrade logic. This follows after what was done in gaia. cosmos/gaia@v5.0.8...v6.0.0-rc3

The line for adding the IBC channel is added, to make the SDK v0.42 -> IBC v1.2.3 update safe.

This also adds authz into the v5 upgrade.
This also adds the IBC v2 upgrade logic.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@ValarDragon ValarDragon changed the title Update app.go to correctly do SDK module upgrade logic Update app.go to correctly do SDK v0.44 module upgrade logic Nov 21, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2021

Codecov Report

Merging #610 (7517880) into main (dedcfb8) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #610      +/-   ##
==========================================
+ Coverage   18.43%   18.44%   +0.01%     
==========================================
  Files         172      172              
  Lines       24203    24233      +30     
==========================================
+ Hits         4462     4470       +8     
- Misses      18977    18998      +21     
- Partials      764      765       +1     
Impacted Files Coverage Δ
app/ante.go 0.00% <ø> (ø)
app/app.go 0.56% <0.00%> (-0.05%) ⬇️
x/txfees/module.go 47.36% <0.00%> (+0.14%) ⬆️
x/incentives/module.go 52.27% <0.00%> (+2.27%) ⬆️
x/lockup/module.go 55.81% <0.00%> (+2.32%) ⬆️
x/gamm/module.go 64.86% <0.00%> (+2.70%) ⬆️
x/mint/module.go 55.55% <0.00%> (+2.77%) ⬆️
x/epochs/module.go 52.77% <0.00%> (+2.77%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dedcfb8...7517880. Read the comment docs.

@ValarDragon ValarDragon marked this pull request as draft November 21, 2021 07:38
@ValarDragon ValarDragon changed the title Update app.go to correctly do SDK v0.44 module upgrade logic Update app.go to correctly do SDK v0.44 module upgrade logic, add authz Nov 21, 2021
@ValarDragon ValarDragon marked this pull request as ready for review November 21, 2021 08:13
@ValarDragon ValarDragon requested a review from sunnya97 November 21, 2021 08:13
app/app.go Outdated Show resolved Hide resolved
@ValarDragon ValarDragon mentioned this pull request Nov 21, 2021
@ValarDragon ValarDragon changed the title Update app.go to correctly do SDK v0.44 module upgrade logic, add authz Update app.go to correctly do module upgrade logic, add authz, IBC v2 Nov 21, 2021
@ValarDragon ValarDragon merged commit f68d6ed into main Nov 21, 2021
@ValarDragon ValarDragon deleted the dev/update_logic_followup branch November 21, 2021 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants