Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golangci: enable unused parameters linter (backport #6018) #6029

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 11, 2023

This is an automatic backport of pull request #6018 done by Mergify.
Cherry-pick of 2e3f19d has failed:

On branch mergify/bp/v16.x/pr-6018
Your branch is up to date with 'origin/v16.x'.

You are currently cherry-picking commit 2e3f19d8.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .golangci.yml
	modified:   CHANGELOG.md
	modified:   app/upgrades/v15/export_test.go
	modified:   app/upgrades/v15/upgrade_test.go
	modified:   app/upgrades/v15/upgrades.go
	modified:   simulation/executor/mock_tendermint.go
	modified:   simulation/executor/util.go
	modified:   simulation/simtypes/txbuilder.go
	modified:   tests/e2e/configurer/upgrade.go
	modified:   tests/e2e/initialization/chain.go
	modified:   tests/e2e/initialization/init.go
	modified:   x/concentrated-liquidity/export_test.go
	modified:   x/concentrated-liquidity/incentives.go
	modified:   x/concentrated-liquidity/pool.go
	modified:   x/concentrated-liquidity/simulation/sim_msgs.go
	modified:   x/downtime-detector/client/cli/query.go
	modified:   x/gamm/simulation/sim_msgs.go
	modified:   x/incentives/client/cli/tx.go
	modified:   x/poolmanager/create_pool.go
	modified:   x/poolmanager/export_test.go
	modified:   x/protorev/client/cli/query.go
	modified:   x/superfluid/keeper/export_test.go
	modified:   x/superfluid/keeper/stake.go
	modified:   x/tokenfactory/keeper/createdenom.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   x/concentrated-liquidity/client/cli/tx.go
	both modified:   x/protorev/keeper/rebalance.go
	both modified:   x/superfluid/keeper/migrate.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* enable unused parameters linter

* enable unparam linter and fix basic unparam warnings

* finish with unparam

* reset deliverTx and mark as nolint

* nolint no favor

* changelog

(cherry picked from commit 2e3f19d)

# Conflicts:
#	x/concentrated-liquidity/client/cli/tx.go
#	x/protorev/keeper/rebalance.go
#	x/superfluid/keeper/migrate.go
@mergify mergify bot added the conflicts label Aug 11, 2023
@mergify mergify bot assigned pysel Aug 11, 2023
@github-actions github-actions bot added C:app-wiring Changes to the app folder C:CLI C:simulator Edits simulator or simulations C:x/concentrated-liquidity C:x/gamm Changes, features and bugs related to the gamm module. C:x/incentives C:x/poolmanager C:x/superfluid C:x/tokenfactory T:CI labels Aug 11, 2023
@p0mvn
Copy link
Member

p0mvn commented Aug 11, 2023

Hello, this is an automated review of your pull request.

Please ensure the following:

  1. Make sure to apply the correct labels to your pull request.
  2. Check that the continuous integration (CI) is not failing.
  3. Add a changelog if necessary. If not added, add the "A:no-changelog" label.
  4. Confirm if state compatibility labels are applied correctly. One of these should be present: "V:state-breaking", "V:state-compatible/backport", "V:state-compatible/no_backport". If "V:state-breaking" is applied, be sure to add a changelog again. If "V:state-compatible/backport", add a label for the version to backport to - the format is "A:backport/v". If "V:state-compatible/no_backport" is applied, please confirm if this should be backported.
  5. Perform a self-review of the changes.
  6. Add tests if necessary.
  7. Once all of the above are complete, please tag @p0mvn for a manual review.

Please note that this message is automated.

@github-actions
Copy link
Contributor

Important Notice

This PR includes modifications to the tests/e2e/initialization module.
Please follow the instructions below:

  1. Backport these changes to the previous Osmosis version's branch.
  2. Run the script inside a Docker container to update genesis and configs for pre-upgrade Osmosis.
  3. Merge the backported changes.
  4. The image will be built and uploaded to Docker Hub here.
  5. Grab the latest image and update it in the PR to the main branch replacing the previousVersionInitTag in the osmosis/tests/e2e/containers/config.go

Please let us know if you need any help.

@faddat
Copy link
Member

faddat commented Aug 12, 2023

@pysel -- this was extremely useful!

Check out the changes in #5127

thank you!

@p0mvn
Copy link
Member

p0mvn commented Aug 18, 2023

This is in v17.x, not worth resolving conflicts here

@p0mvn p0mvn closed this Aug 18, 2023
@mergify mergify bot deleted the mergify/bp/v16.x/pr-6018 branch August 18, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants