Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: reduce the number of returns in superfluid migration #6014

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Aug 10, 2023

Progress towards: #5984

What is the purpose of the change

Reduces the number of returns in superfluid migration to eventually enable a linter, restricting it from happening.

Testing and Verifying

This change is already covered by existing tests

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

@p0mvn p0mvn added V:state/compatible/backport State machine compatible PR, should be backported A:backport/v16.x backport patches to v16.x branch labels Aug 10, 2023
@github-actions github-actions bot added C:x/gamm Changes, features and bugs related to the gamm module. C:x/superfluid and removed A:backport/v16.x backport patches to v16.x branch labels Aug 10, 2023
@p0mvn
Copy link
Member Author

p0mvn commented Aug 10, 2023

@devbot-wizard add changelog api reduce the number of returns in superfluid migration

@p0mvn
Copy link
Member Author

p0mvn commented Aug 10, 2023

devbot add changelog api reduce the number of returns in superfluid migration

@p0mvn
Copy link
Member Author

p0mvn commented Aug 10, 2023

devbot add changelog misc reduce the number of returns in superfluid migration

@p0mvn p0mvn marked this pull request as ready for review August 10, 2023 16:32
Copy link
Member

@czarcas7ic czarcas7ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@p0mvn p0mvn added the A:backport/v16.x backport patches to v16.x branch label Aug 10, 2023
@p0mvn p0mvn merged commit 7a92e78 into main Aug 10, 2023
@p0mvn p0mvn deleted the roman/reduce-num-returns-3 branch August 10, 2023 18:10
mergify bot pushed a commit that referenced this pull request Aug 10, 2023
* refactor: reduce the number of returns in superfluid migration

* changelog

(cherry picked from commit 7a92e78)

# Conflicts:
#	x/gamm/keeper/migrate.go
#	x/superfluid/keeper/export_test.go
#	x/superfluid/keeper/migrate.go
p0mvn added a commit that referenced this pull request Aug 10, 2023
p0mvn added a commit that referenced this pull request Aug 29, 2023
* refactor: reduce the number of returns in superfluid migration

* changelog
@github-actions github-actions bot mentioned this pull request Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v16.x backport patches to v16.x branch C:x/gamm Changes, features and bugs related to the gamm module. C:x/superfluid V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants