-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: reduce the number of returns in superfluid migration #6014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0mvn
added
V:state/compatible/backport
State machine compatible PR, should be backported
A:backport/v16.x
backport patches to v16.x branch
labels
Aug 10, 2023
github-actions
bot
added
C:x/gamm
Changes, features and bugs related to the gamm module.
C:x/superfluid
and removed
A:backport/v16.x
backport patches to v16.x branch
labels
Aug 10, 2023
@devbot-wizard add changelog api reduce the number of returns in superfluid migration |
devbot add changelog api reduce the number of returns in superfluid migration |
devbot add changelog misc reduce the number of returns in superfluid migration |
p0mvn
requested review from
mattverse,
stackman27,
AlpinYukseloglu and
czarcas7ic
as code owners
August 10, 2023 16:32
czarcas7ic
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
mergify bot
pushed a commit
that referenced
this pull request
Aug 10, 2023
* refactor: reduce the number of returns in superfluid migration * changelog (cherry picked from commit 7a92e78) # Conflicts: # x/gamm/keeper/migrate.go # x/superfluid/keeper/export_test.go # x/superfluid/keeper/migrate.go
p0mvn
added a commit
that referenced
this pull request
Aug 10, 2023
p0mvn
added a commit
that referenced
this pull request
Aug 10, 2023
…ort #6014) (#6017) Co-authored-by: Roman <[email protected]>
p0mvn
added a commit
that referenced
this pull request
Aug 29, 2023
* refactor: reduce the number of returns in superfluid migration * changelog
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A:backport/v16.x
backport patches to v16.x branch
C:x/gamm
Changes, features and bugs related to the gamm module.
C:x/superfluid
V:state/compatible/backport
State machine compatible PR, should be backported
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress towards: #5984
What is the purpose of the change
Reduces the number of returns in superfluid migration to eventually enable a linter, restricting it from happening.
Testing and Verifying
This change is already covered by existing tests
Documentation and Release Note
Unreleased
section ofCHANGELOG.md
?Where is the change documented?
x/{module}/README.md
)