osmocli: parse Use field's arguments dynamically from a message

[pysel]

Closes: #XXX

What is the purpose of the change

In current osmocli implementation, in order to create a cli command you need to create a descriptor of this command (example here). The problem with this approach is that it is easy to forget to pass some arguments into Use field of descriptor, which leads to inconsistent Usages of cli commands (example PR which fixes mistakenly dropped arguments).

In this PR I propose to attach arguments dynamically during command construction. It will help avoid the mentioned inconsistencies. If this gets merged, there will be no need to provide message's and query's arguments to descriptors. Ex:

return &osmocli.QueryDescriptor{
	Use:   "position-by-id",  // was <Use:   "position-by-id [positionID]">
        ---- snip ----
},

To reviewers: right now I only implemented it for queries. If folks like the idea of this PR, I will continue to do the same for txs and migrate the repo to the new usage of osmocli

Testing and Verifying

Manual + added test

[pysel]

devbot add changelog misc osmocli: parse Use field's arguments dynamically

[mattverse]

Hey @pysel love this change, I think this is a great idea!

I was manually testing out things, and I noticed that arguments have trouble getting dynamically parsed methods using custom parser or custom logic. Here's an example

(base) matt@MacBook-Pro build % ./osmosisd q gamm estimate-swap-exact-amount-in --help
Query estimate-swap-exact-amount-in.

Example:
$ osmosisd q gamm estimate-swap-exact-amount-in 1 osm11vmx8jtggpd9u7qr0t8vxclycz85u925sazglr7 1000stake --swap-route-pool-ids=2 --swap-route-pool-ids=3

Usage:
  osmosisd query gamm estimate-swap-exact-amount-in [flags]

notice how it failed to dynamically place the usage.
After we get this fixed I think we should be good to go :) Nice work!

[pysel]

hey @mattverse! weird, I just tried it on the same command, seems to be working fine:

ruslanakhtariev@Ruslans-MacBook-Air osmosis % osmosisd q gamm estimate-swap-exact-amount-in -h
Query estimate-swap-exact-amount-in.

Example:
$ <appd> q gamm estimate-swap-exact-amount-in 1 osm11vmx8jtggpd9u7qr0t8vxclycz85u925sazglr7 1000stake --swap-route-pool-ids=2 --swap-route-pool-ids=3

Usage:
  osmosisd query gamm estimate-swap-exact-amount-in [pool-id] [token-in] [routes] [flags]

Flags:
      --height int                   Use a specific height to query state at (this can error if the node is pruning state)
  -h, --help                         help for estimate-swap-exact-amount-in
      --node string                  <host>:<port> to Tendermint RPC interface for this chain (default "tcp://localhost:26657")
  -o, --output string                Output format (text|json) (default "text")
      --swap-route-denoms string     swap route amount
      --swap-route-pool-ids string   swap route pool id

Global Flags:
      --chain-id string     The network chain ID
      --home string         directory for config and data (default "/Users/ruslanakhtariev/.osmosisd")
      --log_format string   The logging format (json|plain) (default "plain")
      --log_level string    The logging level (trace|debug|info|warn|error|fatal|panic) (default "info")
      --trace               print out full stack trace on errors

could you please confirm you used an updated binary? thanks!

[mattverse]

@pysel What is the binary version you see? The current one I have is

(base) matt@MacBook-Pro build % ./osmosisd version
15.8.0-333-gc63b8e409

[pysel]

@mattverse have you installed the binary via go install ./... or via some other way?

[mattverse]

@pysel I use make build and directly use the binary file itself. Maybe it's worth looking into it

[pysel]

@pysel I use make build and directly use the binary file itself. Maybe it's worth looking into it

hey @mattverse, I fixed the problem (it was outdated osmoutils version in go.mod), it should be good now.

[pysel]

btw, this osmoutils version problem took some time to be figured out. I think we might like to revisit PR that was closed recently, which idea was to update versions of workspace's submodules in go.mod when anything in them changes. if we had this functionality, the mentioned problem wouldn't have occurred, wdyt?

EDIT: another option is to maybe add this functionality to devbot. cc: @ValarDragon

cc: @mattverse @p0mvn @czarcas7ic

[mattverse]

I'm down to re-reviewing #4667, sorry for the delay on the review for that one

[mattverse]

LGTM, nice work 🌮