Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[e2e]: e2e failure fixes #5964

Merged
merged 5 commits into from
Aug 4, 2023
Merged

Conversation

czarcas7ic
Copy link
Member

@czarcas7ic czarcas7ic commented Aug 4, 2023

Closes: #XXX

Med/High confidence fix for concurrent map write

An example of the concurrent map write error https://github.com/osmosis-labs/osmosis/actions/runs/5754011094/job/15607044536

Adds a mutex to prevent this from happening

Low/Med confidence fix for nodes not starting

There are random times (rare, maybe 1 in 100, both locally and in CI) when a docker container just wont start. While this isn't the best fix, this deletes the faulty container and attempt to recreate it instead of just failing on the spot.

An example of this happening https://github.com/osmosis-labs/osmosis/actions/runs/5719951506/job/15498941705

@czarcas7ic czarcas7ic added V:state/compatible/no_backport State machine compatible PR, depends on prior breaks A:no-changelog labels Aug 4, 2023
@czarcas7ic czarcas7ic changed the title fix[e2e]: prevent concurrent map write error fix[e2e]: e2e failure fixes Aug 4, 2023
@czarcas7ic czarcas7ic marked this pull request as ready for review August 4, 2023 20:40
@ValarDragon
Copy link
Member

devbot add changelog fix e2e test concurrency bugs

@ValarDragon ValarDragon merged commit 7bbcc9f into main Aug 4, 2023
@ValarDragon ValarDragon deleted the adam/prevent-concurrent-map-write branch August 4, 2023 23:29
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:no-changelog V:state/compatible/no_backport State machine compatible PR, depends on prior breaks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants