Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade to sdk v0.50.x #5952

Closed
wants to merge 3 commits into from
Closed

Conversation

faddat
Copy link
Member

@faddat faddat commented Aug 3, 2023

What is the purpose of the change

  • Upgrade Osmosis to v0.50.x
  • Identify which of Osmosis' dependencies will need upgrades when Osmosis upgrades to v0.50.x

Testing and Verifying

For now, there's not a good reason to test this PR signficantly. It is unlikely to work until an upgraded
packet-forward-middleware and other dependencies have bene completed.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

Important Notice

This PR includes modifications to the tests/e2e/initialization module.
Please follow the instructions below:

  1. Backport these changes to the previous Osmosis version's branch.
  2. Run the script inside a Docker container to update genesis and configs for pre-upgrade Osmosis.
  3. Merge the backported changes.
  4. The image will be built and uploaded to Docker Hub here.
  5. Grab the latest image and update it in the PR to the main branch replacing the previousVersionInitTag in the osmosis/tests/e2e/containers/config.go

Please let us know if you need any help.

@faddat faddat mentioned this pull request Aug 3, 2023
github.com/cosmos/cosmos-proto v1.0.0-beta.2
github.com/cosmos/cosmos-sdk v0.47.4
github.com/cosmos/cosmos-proto v1.0.0-beta.3
github.com/cosmos/cosmos-sdk v0.50.0-beta.0.0.20230802171422-ee5b2e3afc4f
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this the version with the bank hooks figured out?

@mattverse
Copy link
Member

Thanks for the PR @faddat, we are still currently figuring out ways to most efficiently unfork sdk whilst having our changes upstreamed: we're also down to have the next major upgrade soley focused on unforking sdk, upgrading to 50 (if possible). But as mentioned, we still have not figured out if we want to upgrade to v0.50, or even if its possible to do so, so my recommendation would be punting further work for this until we have a fixed decision made! wdyt?

@faddat
Copy link
Member Author

faddat commented Aug 7, 2023 via email

@mattverse
Copy link
Member

Sounds great, thanks!

@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you!

@github-actions github-actions bot added the Stale label Aug 22, 2023
@github-actions github-actions bot closed this Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants