-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: upgrade to sdk v0.50.x #5952
Conversation
Important Notice This PR includes modifications to the
Please let us know if you need any help. |
github.com/cosmos/cosmos-proto v1.0.0-beta.2 | ||
github.com/cosmos/cosmos-sdk v0.47.4 | ||
github.com/cosmos/cosmos-proto v1.0.0-beta.3 | ||
github.com/cosmos/cosmos-sdk v0.50.0-beta.0.0.20230802171422-ee5b2e3afc4f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this the version with the bank hooks figured out?
Thanks for the PR @faddat, we are still currently figuring out ways to most efficiently unfork sdk whilst having our changes upstreamed: we're also down to have the next major upgrade soley focused on unforking sdk, upgrading to 50 (if possible). But as mentioned, we still have not figured out if we want to upgrade to v0.50, or even if its possible to do so, so my recommendation would be punting further work for this until we have a fixed decision made! wdyt? |
Hey Matt, actually my thought on this is that it might be best to do an
investigation into it and then provide you guys with the results but also
if you would like us to wait that's totally fine.
I'll bring some thoughts to you guys in slack, I think.
So I think that a unique challenge that we are going to face is that we're
going to have a pretty hard time defining the appropriate steps for the
upgrade without some effort into actually doing the upgrade, but I will get
you some information in slack and wait to hear back from you before
investing a ton more time.
…On Mon, Aug 7, 2023, 2:58 PM Matt, Park ***@***.***> wrote:
Thanks for the PR @faddat <https://github.com/faddat>, we are still
currently figuring out ways to most efficiently unfork sdk whilst having
our changes upstreamed: we're also down to have the next major upgrade
soley focused on unforking sdk, upgrading to 50 (if possible). But as
mentioned, we still have not figured out if we want to upgrade to v0.50, or
even if its possible to do so, so my recommendation would be punting
further work for this until we have a fixed decision made! wdyt?
—
Reply to this email directly, view it on GitHub
<#5952 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABWPVCPDARJ2URNAKUFYR23XUCGYXANCNFSM6AAAAAA3CKQOFU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sounds great, thanks! |
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you! |
What is the purpose of the change
Testing and Verifying
For now, there's not a good reason to test this PR signficantly. It is unlikely to work until an upgraded
packet-forward-middleware and other dependencies have bene completed.
Documentation and Release Note
Unreleased
section ofCHANGELOG.md
?Where is the change documented?
x/{module}/README.md
)