fix(ProtoRev): Parameterizing Pool Type Information #5948
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -73,23 +73,62 @@ message RouteStatistics { | |
| repeated uint64 route = 3 [ (gogoproto.moretags) = "yaml:\"route\"" ]; | ||
| } | ||
|
|
||
| // InfoByPoolType contains information pertaining to how expensive (in terms of | ||
| // gas and time) it is to execute a swap on a given pool type. This distinction | ||
| // is made and necessary because the execution time ranges significantly between | ||
| // the different pool types. | ||
| message InfoByPoolType { | ||
| // The stable pool info | ||
| StablePoolInfo stable = 1 [ | ||
| (gogoproto.moretags) = "yaml:\"stable\"", | ||
| (gogoproto.nullable) = false | ||
| ]; | ||
| // The balancer pool info | ||
| BalancerPoolInfo balancer = 2 [ | ||
| (gogoproto.moretags) = "yaml:\"balancer\"", | ||
| (gogoproto.nullable) = false | ||
| ]; | ||
| // The concentrated pool info | ||
| ConcentratedPoolInfo concentrated = 3 [ | ||
| (gogoproto.moretags) = "yaml:\"concentrated\"", | ||
| (gogoproto.nullable) = false | ||
| ]; | ||
| // The cosmwasm pool info | ||
| CosmwasmPoolInfo cosmwasm = 4 [ | ||
| (gogoproto.moretags) = "yaml:\"cosmwasm\"", | ||
| (gogoproto.nullable) = false | ||
| ]; | ||
| } | ||
|
|
||
| // StablePoolInfo contains meta data pertaining to a stableswap pool type. | ||
| message StablePoolInfo { | ||
| // The weight of a stableswap pool | ||
| uint64 weight = 1 [ (gogoproto.moretags) = "yaml:\"weight\"" ]; | ||
| } | ||
|
|
||
| // BalancerPoolInfo contains meta data pertaining to a balancer pool type. | ||
| message BalancerPoolInfo { | ||
| // The weight of a balancer pool | ||
| uint64 weight = 1 [ (gogoproto.moretags) = "yaml:\"weight\"" ]; | ||
| } | ||
|
|
||
| // ConcentratedPoolInfo contains meta data pertaining to a concentrated pool | ||
| // type. | ||
| message ConcentratedPoolInfo { | ||
| // The weight of a concentrated pool | ||
| uint64 weight = 1 [ (gogoproto.moretags) = "yaml:\"weight\"" ]; | ||
| // The maximum number of ticks we can move when rebalancing | ||
| uint64 max_ticks_crossed = 2 | ||
| [ (gogoproto.moretags) = "yaml:\"max_ticks_crossed\"" ]; | ||
| } | ||
|
|
||
| // CosmwasmPoolInfo contains meta data pertaining to a cosmwasm pool type. | ||
| message CosmwasmPoolInfo { | ||
| // The weight of a cosmwasm pool (by contract address) | ||
| map<string, uint64> weight_map = 1 [ | ||
|
There was a problem hiding this comment. I'm not sure if using a map is problematic for app hashing. We do no iterations on the map itself in the module. The primary use case is determining the number of pool weight of a given cosmwasm pool (which may vary across applications which is why its mapped to contract addresses). There was a problem hiding this comment. @ValarDragon can you verify the safety of this? There was a problem hiding this comment. We had instances where we tried to use maps quite a while ago, I think the decision back then was to try avoid using maps for extra safety, would it be possible to change it so tht we use repeated structs instead here? There was a problem hiding this comment. got it. ty for confirming |
||
| (gogoproto.moretags) = "yaml:\"weight_map\"", | ||
| (gogoproto.nullable) = false | ||
| ]; | ||
| } | ||
|
|
||
| // BaseDenom represents a single base denom that the module uses for its | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are renaming the proto field, we should depreciate this field and add a new one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Or reserve!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to clarify, add a note that this is deprecated and adding a new field?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added back the previous field with a note that it is being deprecated.