Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Fix valset amino codec #5938

Merged
merged 2 commits into from
Aug 1, 2023
Merged

Chore: Fix valset amino codec #5938

merged 2 commits into from
Aug 1, 2023

Conversation

stackman27
Copy link
Contributor

Closes: #XXX

What is the purpose of the change

Fix Valset Amino codec to use in telescope

Testing and Verifying

n/a

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

@stackman27 stackman27 requested a review from mattverse as a code owner August 1, 2023 04:59
@stackman27 stackman27 requested a review from jonator August 1, 2023 04:59
@stackman27 stackman27 added A:no-changelog V:state/breaking State machine breaking PR labels Aug 1, 2023
mattverse
mattverse requested changes Aug 1, 2023
View reviewed changes
Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Char count over 40 char, this would cause errors when signing with ledger

x/valset-pref/types/codec.go Outdated Show resolved Hide resolved
@stackman27 stackman27 requested a review from mattverse August 1, 2023 06:34
@ValarDragon ValarDragon merged commit 87c6917 into main Aug 1, 2023
@ValarDragon ValarDragon deleted the stack/valset-codec branch August 1, 2023 12:52
@ValarDragon
Copy link
Member

Ah I shouldn't have merged this, this should have had a changelog entry.

Can you add a changelog in subsequent PR @stackman27 ?

@stackman27
Copy link
Contributor Author

Ah I shouldn't have merged this, this should have had a changelog entry.

Can you add a changelog in subsequent PR @stackman27 ?

yup will do

@github-actions github-actions bot mentioned this pull request Apr 15, 2024
Closed
@github-actions github-actions bot mentioned this pull request May 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattverse mattverse mattverse approved these changes

@jonator jonator Awaiting requested review from jonator

Assignees
No one assigned
Labels
A:no-changelog V:state/breaking State machine breaking PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stackman27 @ValarDragon @mattverse