CL: Initialize tick minor gas optimization & cleanup #5923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValarDragon
changed the title
ValarDragon
commented
Jul 30, 2023
| @@ -40,7 +40,7 @@ type positionAndLiquidity struct { | |||
| } | |||
|
|
|||
| func TestFuzz_Many(t *testing.T) { | |||
| fuzz(t, defaultNumSwaps, defaultNumPositions, 100) | |||
| fuzz(t, defaultNumSwaps, defaultNumPositions, 10) | |||
There was a problem hiding this comment.
Driveby change, now that were through CL, running 100 iterations on every save & CI run no longer make sense. (It also makes test on save expensive!)
ValarDragon
commented
Jul 30, 2023
Comment on lines
+135
to
+138
| pool, err := k.getPoolById(ctx, poolId) | ||
| if err != nil { | ||
| return tickStruct, err | ||
| } |
There was a problem hiding this comment.
This is the core change, along with using pool as the arg for the next 3 functions
AlpinYukseloglu
approved these changes
Jul 31, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is simplifying the
GetTickInfocode, by moving the initialization logic to its own function. Furthermore, we only get the pool once, removing repeated gets in every function this would otherwise call. (Saving a net of 2 GetPool operations). This has an added benefit of removing messiness from the test code, where it attempted to generate test cases with invalid pool ID's.The remainder of this PR is cleaning up tests.
The "TestGetInitialSpreadRewardGrowthOppositeDirectionOfLastTraversalForTick" was extremely messy, so just re-wrote the edge case that idt even makes sense to test into its own function, and made the main test use standard helpers.