Remove ExponentAtPriceOne From Gov Prop CreateConcentratedPool #5900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stackman27
force-pushed
the
stack/remove-exp
branch
from
0466497 to
23f3d3f
Compare
czarcas7ic
approved these changes
Aug 2, 2023
| (gogoproto.nullable) = false | ||
| ]; | ||
| string spread_factor = 5 [ | ||
| string spread_factor = 4 [ |
There was a problem hiding this comment.
You need to skip field 4 and leave spread factor at field 5 (there is a contract with protos that when a field is registered it will always be that field unless removed)
There was a problem hiding this comment.
i didn't know about this, is there documentation i can read? I always assumed that if we delete we just decrement the number
There was a problem hiding this comment.
There was a problem hiding this comment.
So we should also reserve the field as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #5894
What is the purpose of the change
Remove expAtone
Testing and Verifying
localosmosis tested
Documentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)