Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat Query: single CFMM <> CL links list #5887

Merged
merged 3 commits into from
Jul 26, 2023
Merged

feat Query: single CFMM <> CL links list #5887

merged 3 commits into from
Jul 26, 2023

Conversation

stackman27
Copy link
Contributor

@stackman27 stackman27 commented Jul 25, 2023 •
edited
Loading

Closes: #5868

What is the purpose of the change

added query for cfmm <> CL query list

Testing and Verifying

localosmosis tested

/osmosis # osmosisd q gamm cfmm-cl-pool-links  
migration_records:
  balancer_to_concentrated_pool_links:
  - balancer_pool_id: "1"
    cl_pool_id: "6"
  - balancer_pool_id: "2"
    cl_pool_id: "4"

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

@github-actions github-actions bot added C:CLI C:x/gamm Changes, features and bugs related to the gamm module. labels Jul 25, 2023
@stackman27 stackman27 added V:state/breaking State machine breaking PR A:no-changelog labels Jul 25, 2023
@stackman27 stackman27 marked this pull request as ready for review July 25, 2023 22:50
czarcas7ic
czarcas7ic approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@czarcas7ic czarcas7ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍

x/gamm/client/cli/query.go Outdated Show resolved Hide resolved
@czarcas7ic czarcas7ic merged commit c75ad9f into main Jul 26, 2023
@czarcas7ic czarcas7ic deleted the stack/migration-query branch July 26, 2023 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czarcas7ic czarcas7ic czarcas7ic approved these changes

@mattverse mattverse Awaiting requested review from mattverse mattverse is a code owner

@p0mvn p0mvn Awaiting requested review from p0mvn p0mvn is a code owner

Assignees
No one assigned
Labels
A:no-changelog C:CLI C:x/gamm Changes, features and bugs related to the gamm module. V:state/breaking State machine breaking PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Query: single CFMM <> CL links list
2 participants
@stackman27 @czarcas7ic