test: validate negative interval accumulation does not panic when serialized #5873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ialized and deserialized
p0mvn
added
V:state/compatible/no_backport
mattverse
reviewed
Jul 24, 2023
|
|
||
| export := s.clk.ExportGenesis(s.Ctx) | ||
|
|
||
| s.SetupTest() |
There was a problem hiding this comment.
why are we calling SetupTest here again?
There was a problem hiding this comment.
It clears any state created earlier so when we init gen we are doing so from scratch
czarcas7ic
approved these changes
Jul 24, 2023
czarcas7ic
added a commit
that referenced
this pull request
Aug 1, 2023
…5872) * fix/test/docs: negative interval accumulation with spread rewards * changelog * updates * go mod * fix/test/docs: negative interval accumulation with incentive rewards * changelog * updates * update go.mod * test: validate negative interval accumulation does not panic when serialized and deserialized (#5873) * update osmoutils * go mod tidy --------- Co-authored-by: Adam Tucker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #5854
What is the purpose of the change
This test is a final sanity check to ensure that negative interval accumulation (that is
DecCoins) do not panic when serialized or deserializedTesting and Verifying
Added test
Documentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)