Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protorev: Remove v14 from rest endpoints #5870

Merged
merged 5 commits into from
Jul 28, 2023
Merged

Protorev: Remove v14 from rest endpoints #5870

merged 5 commits into from
Jul 28, 2023

Conversation

NotJeremyLiu
Copy link
Contributor

@NotJeremyLiu NotJeremyLiu commented Jul 18, 2023 •
edited
Loading

What is the purpose of the change

  • Protorev had a v14/ separator in its rest endpoints that should not be there, this PR removes them

Testing and Verifying

  • Tested by running localosmosis and querying the endpoints without the v14/ separator

Documentation and Release Note

  • Added changelog entry

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

@github-actions github-actions bot added the C:docs Improvements or additions to documentation label Jul 18, 2023
@NotJeremyLiu NotJeremyLiu mentioned this pull request Jul 18, 2023
Closed
10 tasks
@NotJeremyLiu NotJeremyLiu added api-breaking Breaking changes that impact API only (not state machine). A:no-changelog V:state/compatible/no_backport State machine compatible PR, depends on prior breaks labels Jul 18, 2023
@NotJeremyLiu NotJeremyLiu force-pushed the jl/remove-v14-in-protorev-rest-endpoint branch from 920d1a4 to 938909f Compare July 27, 2023 21:30
@NotJeremyLiu NotJeremyLiu marked this pull request as ready for review July 27, 2023 21:36
@NotJeremyLiu NotJeremyLiu requested a review from p0mvn as a code owner July 27, 2023 21:36
@NotJeremyLiu NotJeremyLiu requested review from stackman27 and removed request for p0mvn July 27, 2023 21:36
mattverse
mattverse reviewed Jul 28, 2023
View reviewed changes
Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NotJeremyLiu Can we run make docs before merging?

@NotJeremyLiu NotJeremyLiu force-pushed the jl/remove-v14-in-protorev-rest-endpoint branch from da5e79d to 4657567 Compare July 28, 2023 13:05
@NotJeremyLiu NotJeremyLiu mentioned this pull request Jul 28, 2023
Merged
@github-actions github-actions bot added the C:CLI label Jul 28, 2023
@ValarDragon ValarDragon merged commit 6ba7191 into main Jul 28, 2023
@ValarDragon ValarDragon deleted the jl/remove-v14-in-protorev-rest-endpoint branch July 28, 2023 19:16
VitalyV1337 pushed a commit to VitalyV1337/osmosis-1 that referenced this pull request Jul 31, 2023
@NotJeremyLiu @VitalyV1337
Protorev: Remove v14 from rest endpoints (osmosis-labs#5870)
3520aa3 
* Remove v14 from protos and run proto gen

* add changelog entry

* run make proto-all

* run make-docs (osmosis-labs#5905)

* run make proto-all
@github-actions github-actions bot mentioned this pull request May 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattverse mattverse mattverse approved these changes

@stackman27 stackman27 Awaiting requested review from stackman27

Assignees
No one assigned
Labels
A:no-changelog api-breaking Breaking changes that impact API only (not state machine). C:CLI C:docs Improvements or additions to documentation V:state/compatible/no_backport State machine compatible PR, depends on prior breaks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NotJeremyLiu @mattverse @ValarDragon