Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower epoch I/O time by 2-3x #561

Merged
merged 1 commit into from
Oct 29, 2021
Merged

Lower epoch I/O time by 2-3x #561

merged 1 commit into from
Oct 29, 2021

Conversation

ValarDragon
Copy link
Member

Closes: #XXX

Description

Quick fix to improve I/O time. It will instead take more RAM, but this is expected to be minimal


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (v4.x@fe9f8b1). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             v4.x     #561   +/-   ##
=======================================
  Coverage        ?   20.15%           
=======================================
  Files           ?      164           
  Lines           ?    23165           
  Branches        ?        0           
=======================================
  Hits            ?     4669           
  Misses          ?    17743           
  Partials        ?      753           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe9f8b1...42a3f89. Read the comment docs.

@ValarDragon
Copy link
Member Author

This worked through Epoch succesfully on my node. (So no state breaks detected)

Cryptocrew and blockpane also tested this version today, with it working and great notes wrt performance:

Screenshot 2021-10-29 at 12 50 13 PM

Screenshot 2021-10-29 at 12 50 20 PM

going to merge!

@ValarDragon ValarDragon merged commit 7bc69ca into v4.x Oct 29, 2021
@ValarDragon ValarDragon deleted the dev/lower_epoch_io branch October 29, 2021 17:51
ValarDragon added a commit that referenced this pull request Nov 19, 2021
ValarDragon added a commit that referenced this pull request Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants