-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: import cycle resolution with migration records #5596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:app-wiring
Changes to the app folder
C:CLI
C:x/concentrated-liquidity
C:x/gamm
Changes, features and bugs related to the gamm module.
C:x/pool-incentives
C:x/superfluid
labels
Jun 21, 2023
6 tasks
czarcas7ic
reviewed
Jun 21, 2023
czarcas7ic
reviewed
Jun 21, 2023
Co-authored-by: Adam Tucker <[email protected]>
Co-authored-by: Adam Tucker <[email protected]>
czarcas7ic
approved these changes
Jun 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, thanks for getting this done
p0mvn
added
V:state/compatible/no_backport
State machine compatible PR, depends on prior breaks
A:no-changelog
V:state/breaking
State machine breaking PR
and removed
V:state/compatible/no_backport
State machine compatible PR, depends on prior breaks
labels
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A:no-changelog
C:app-wiring
Changes to the app folder
C:CLI
C:x/concentrated-liquidity
C:x/gamm
Changes, features and bugs related to the gamm module.
C:x/pool-incentives
C:x/superfluid
V:state/breaking
State machine breaking PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
Discussed with Adam and agreed to add this import cycle resolution PR if it can be achieved under 20 mins.
The solution is to generate migration protos in a separate package so that the import cycles are removed.
Testing and Verifying
This change is a trivial rework / code cleanup without any test coverage.
Documentation and Release Note
Unreleased
section ofCHANGELOG.md
?Where is the change documented?
x/{module}/README.md
)