Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CL] Changes from audit results (2/3) #5587

Merged
merged 1 commit into from
Jun 21, 2023
Merged

[CL] Changes from audit results (2/3) #5587

merged 1 commit into from
Jun 21, 2023

Conversation

mattverse
Copy link
Member

Closes: #XXX

What is the purpose of the change

This PR adds some more changes from the audit results

Testing and Verifying

Ensures that existing test cases pass

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

@mattverse mattverse added V:state/compatible/no_backport State machine compatible PR, depends on prior breaks A:no-changelog labels Jun 20, 2023
p0mvn
p0mvn approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@p0mvn p0mvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

czarcas7ic
czarcas7ic approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@czarcas7ic czarcas7ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, merging

@czarcas7ic czarcas7ic merged commit 3311123 into main Jun 21, 2023
@czarcas7ic czarcas7ic deleted the mattverse/informal-2 branch June 21, 2023 16:03
@mtsitrin mtsitrin mentioned this pull request Dec 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czarcas7ic czarcas7ic czarcas7ic approved these changes

@p0mvn p0mvn p0mvn approved these changes

@nicolaslara nicolaslara Awaiting requested review from nicolaslara nicolaslara is a code owner

Assignees
No one assigned
Labels
A:no-changelog C:x/concentrated-liquidity C:x/txfees V:state/compatible/no_backport State machine compatible PR, depends on prior breaks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattverse @p0mvn @czarcas7ic