Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IBC checktx antehandler to v4.x #556

Merged
merged 1 commit into from
Oct 29, 2021
Merged

Conversation

ValarDragon
Copy link
Member

Description

Uses the IBC check tx ante handler from cosmos/cosmos-sdk#10211, that prevents redundant IBC txs from getting proposed


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@ValarDragon
Copy link
Member Author

Lets check this on a node before merging. (The v4.x branch didn't pass lint to begin with)

cc @UnityChaos

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (v4.x@c4b5b0e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             v4.x     #556   +/-   ##
=======================================
  Coverage        ?   20.12%           
=======================================
  Files           ?      164           
  Lines           ?    23147           
  Branches        ?        0           
=======================================
  Hits            ?     4659           
  Misses          ?    17735           
  Partials        ?      753           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4b5b0e...d6a0420. Read the comment docs.

@UnityChaos
Copy link
Member

Works for me so far 👍

@ValarDragon ValarDragon merged commit fe9f8b1 into v4.x Oct 29, 2021
@ValarDragon ValarDragon deleted the dev/add_ibc_checktx_to_v4x branch October 29, 2021 04:29
ValarDragon added a commit that referenced this pull request Nov 19, 2021
ValarDragon added a commit that referenced this pull request Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants