chore: standardize ibc-go and tendermint imports #5520
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faddat
changed the title
|
Hey thanks for the PR and investigation of whats going on here! I think we should close until next release right now, due to review capacity right now though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #5517
What is the purpose of the change
This PR allows osmosis to use the standard v4.4.1 ibc-go
Testing and Verifying
N/A
Documentation and Release Note
Unreleasedsection ofCHANGELOG.md? noWhere is the change documented?
x/{module}/README.md)Hey @MattPark, I found this and I kinda figured that it mattered -- if you think it doesn't please feel free to just close it.
If it matters, then we should also likely merge:
I also found some similar stuff blocking the use of comet in Osmsois, and I'm putting together an issue now. The PR came before the issue because I wanted to confirm what was going on.