Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CL] Demo non-monotinicity of approx root using hand picked values #5518

Closed
wants to merge 1 commit into from

Conversation

AlpinYukseloglu
Copy link
Contributor

@AlpinYukseloglu AlpinYukseloglu commented Jun 14, 2023

Ref: #5517

What is the purpose of the change

This branch demonstrates that our ApproxRoot function is non-monotonic using hand picked inputs.

Testing and Verifying

N/A

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

@ValarDragon
Copy link
Member

ty for making this!

@ValarDragon
Copy link
Member

This doesn't demonstrate the problem, because these have equal square roots. Its fine (necessary even) for them to be allowed to be equal under the SDK decimal representation. We could only hope to avoid that with precision limits or floats

@AlpinYukseloglu
Copy link
Contributor Author

Hm. I was operating under the definition "if p1 > p0, then f(p1) > f(p0) independent of error in f" brought up in previous discussions when I made this, but this does make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:no-changelog V:state/compatible/no_backport State machine compatible PR, depends on prior breaks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants