Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CL]: Fix bound check bug for liquidity amounts #5474

Closed
wants to merge 2 commits into from

Conversation

AlpinYukseloglu
Copy link
Contributor

Closes: #XXX

What is the purpose of the change

This PR fixes an incorrect bound check in liquidity calculation logic.

Testing and Verifying

Relevant tests are in math_test.go. Higher level functional tests will also be covering this functionality in randomized tests.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

@AlpinYukseloglu
Copy link
Contributor Author

Closing this in favor of #5557, which has a much simpler/cleaner solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant