Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turnpike/f1 fee distribution #543
Turnpike/f1 fee distribution #543
Changes from 86 commits
a67285d
dbc93c9
8ec039f
bc45a60
fc9f946
90269c8
eccfe6a
9d2455b
c1fc823
30a4673
7b5b361
20a57ae
ac50ef2
d748513
52db9e0
5b2df12
7544095
62ba4bb
a637140
6b6202c
dc0e878
89695bf
620d799
4db3b5d
c601bf1
1357edd
a99f483
c98a0fb
78b79a3
df484ee
f7ac06f
2d20556
3a8b103
0dd2f70
271e6d7
4e46cca
d2d92f6
11e00dd
6fc12ca
739d795
d49d92a
c2a311e
4d201fe
15a61a6
9939ea9
13a52f8
13a553a
d8ebdcc
011b044
0cdf7c4
e412d43
a059244
96a028a
011efeb
384e738
cbe1af6
68477ec
1529650
4616d8d
0bc6dc3
5a7c406
d5ded84
7b0459a
621d0c2
ce22345
f0457c7
f5ec2eb
08a0256
29fec51
bb36586
ca8fba4
d0a10bf
60e052c
60f5254
74c8857
2798ebd
911b3f9
218ec85
9df7007
0b23ba2
5c18832
f21c894
b0aaa0d
6db80ec
85f2615
0155e64
a7a907e
c2a5e66
7b4b8b8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do these get deserialized into golang? A common problem if its a hashmap is that hashmap iteration is non-deterministic. So typically these get serialized as repeated lists of a (string, uint64) pairs, where that pair is renamed.
Or is the idea that this is a query, not part of the state machine, so its fine? If so, can a comment be added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review. hash map is also used in another data structure. Your point is correct and I will PR with other fixes + queries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
option (gogoproto.stable_marshaler) = true;
above line is added to message using maps to secure iteration order and contiguous memory usage