refactor/test(x/cosmwasmpool): tokenfactory shares and updated transmuter #5381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0mvn
added
V:state/compatible/no_backport
p0mvn
commented
Jun 1, 2023
Comment on lines
+34
to
+36
| // For choice, see: https://github.com/osmosis-labs/osmosis/pull/4983 | ||
| DenomCreationFee: sdk.NewCoins(), // used to be 10 OSMO at launch. | ||
| DenomCreationGasConsume: uint64(DefaultCreationGasFee), |
There was a problem hiding this comment.
See discussion for context: https://osmosis-network.slack.com/archives/C04LZFBHGQ5/p1685588880275719?thread_ts=1685506174.651869&cid=C04LZFBHGQ5
Also, see this: #4983
|
I saw the simulator failure and will address it tomorrow. If everything else looks good, please ACK the PR, and I will merge it after fixing the simulator |
iboss-ptk
approved these changes
Jun 1, 2023
github-actions
bot
added
C:simulator
pysel
pushed a commit
that referenced
this pull request
Jun 6, 2023
…uter (#5381) * new-transmuter * refactor/test(x/cosmwasmpool): tokenfactory shares and updated transmuter * updates * updates * fix test * disable simulator * update transmuter * correct share * fix test AGAIN * fix test * fix problem * fix * update test * updates * remove
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
This PR implements the change documented in: #5350
With the transmuter contract from this branch: https://github.com/osmosis-labs/transmuter/tree/share_token
Testing and Verifying
Functionally tests the transmuter tokenfactory shares.
Documentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)