feat: add ica authorized messages in upgrade handler #5380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0mvn
reviewed
Jun 1, 2023
mattverse
reviewed
Jun 1, 2023
p0mvn
approved these changes
Jun 1, 2023
p0mvn
reviewed
Jun 2, 2023
app/upgrades/v16/upgrades.go
Outdated
Comment on lines
81
to
94
| // Add both MsgExecuteContract and MsgInstantiateContract to the list of allowed messages. | ||
| hostParams := keepers.ICAHostKeeper.GetParams(ctx) | ||
| exists := false | ||
| for _, msg := range hostParams.AllowMessages { | ||
| if msg == sdk.MsgTypeURL(&cosmwasmtypes.MsgExecuteContract{}) || msg == sdk.MsgTypeURL(&cosmwasmtypes.MsgInstantiateContract{}) { | ||
| exists = true | ||
| break | ||
| } | ||
| } | ||
| if !exists { | ||
| hostParams.AllowMessages = append(hostParams.AllowMessages, sdk.MsgTypeURL(&cosmwasmtypes.MsgExecuteContract{})) | ||
| hostParams.AllowMessages = append(hostParams.AllowMessages, sdk.MsgTypeURL(&cosmwasmtypes.MsgInstantiateContract{})) | ||
| keepers.ICAHostKeeper.SetParams(ctx, hostParams) | ||
| } |
There was a problem hiding this comment.
I have some comments but I'm going to make the changes directly to save time on back and forth
There was a problem hiding this comment.
@czarcas7ic can you ACK this change and we merge?
There was a problem hiding this comment.
Got ACK on Slack, going to merge upon CI passing
pysel
pushed a commit
that referenced
this pull request
Jun 6, 2023
* add ica auth messages * append instead * check if message is in list before adding * updates --------- Co-authored-by: Roman <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
Whitelists the cosmwasm MsgExecuteContract and MsgInstantiateContract for ICA in the v16 upgrade handler.
Testing and Verifying
(Please pick one of the following options)
This change has been done in multiple upgrade handlers previously.
Documentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)