Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update e2e genesis config for protorev module #5312

Merged
merged 1 commit into from
May 25, 2023
Merged

update e2e genesis config for protorev module #5312

merged 1 commit into from
May 25, 2023

Conversation

NotJeremyLiu
Copy link
Contributor

@NotJeremyLiu NotJeremyLiu commented May 25, 2023 •
edited
Loading

What is the purpose of the change

  • v16 upgrade changes protorev to pay dev account after every trade, instead of tracking it in a kvstore and paying out on a weekly basis
  • This PR adds a dev account to the ProtoRev module in e2e test to properly test that the v16 upgrade sends left over dev funds tracked in the kvstore to the dev account during the upgrade.

Testing and Verifying

  • Testing will happen in a future PR that implements protorev's v16 upgrade.

Documentation and Release Note

  • No new documentation added

@NotJeremyLiu NotJeremyLiu added A:no-changelog V:state/compatible/backport State machine compatible PR, should be backported A:backport/v15.x backport patches to v15.x branch labels May 25, 2023
@NotJeremyLiu NotJeremyLiu marked this pull request as ready for review May 25, 2023 20:28
@NotJeremyLiu NotJeremyLiu requested review from stackman27 and p0mvn May 25, 2023 20:29
@NotJeremyLiu NotJeremyLiu mentioned this pull request May 25, 2023
Merged
@p0mvn p0mvn merged commit d606177 into main May 25, 2023
@p0mvn p0mvn deleted the jl/update-protorev-e2e-init-for-v16-upgrade branch May 25, 2023 20:51
mergify bot pushed a commit that referenced this pull request May 25, 2023
@NotJeremyLiu @mergify
update e2e genesis config for protorev module (#5312)
28ff0a4 
(cherry picked from commit d606177)
@mergify mergify bot mentioned this pull request May 25, 2023
Merged
p0mvn pushed a commit that referenced this pull request May 25, 2023
@mergify @NotJeremyLiu
update e2e genesis config for protorev module (#5312) (#5316)
63e3f05 
(cherry picked from commit d606177)

Co-authored-by: Jeremy Liu <[email protected]>
@NotJeremyLiu NotJeremyLiu mentioned this pull request May 25, 2023
Merged
pysel pushed a commit that referenced this pull request Jun 6, 2023
@NotJeremyLiu @pysel
update e2e genesis config for protorev module (#5312)
5856fb1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p0mvn p0mvn p0mvn approved these changes

@stackman27 stackman27 Awaiting requested review from stackman27

Assignees
No one assigned
Labels
A:backport/v15.x backport patches to v15.x branch A:no-changelog V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NotJeremyLiu @p0mvn