Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add pool link to benchmark #5291

Merged
merged 1 commit into from
May 25, 2023
Merged

chore: add pool link to benchmark #5291

merged 1 commit into from
May 25, 2023

Conversation

czarcas7ic
Copy link
Member

@czarcas7ic czarcas7ic commented May 24, 2023 •
edited
Loading

Closes: #XXX

What is the purpose of the change

Adds pool link between balancer and CL pool in the benchmark setup

@czarcas7ic czarcas7ic added V:state/compatible/no_backport State machine compatible PR, depends on prior breaks A:no-changelog labels May 24, 2023
@czarcas7ic czarcas7ic marked this pull request as ready for review May 24, 2023 22:01
@czarcas7ic czarcas7ic requested a review from p0mvn as a code owner May 24, 2023 22:01
p0mvn
p0mvn approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@p0mvn p0mvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the quick change.

Can we merge its after getting improvements from #5287 in? I can hit the merge button once ready

Would like to keep the current setup for the problems that have been identified already

mattverse
mattverse approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@p0mvn p0mvn merged commit 1e56cc6 into main May 25, 2023
@p0mvn p0mvn deleted the adam/add-pool-link-bench branch May 25, 2023 16:03
pysel pushed a commit that referenced this pull request Jun 6, 2023
@czarcas7ic @pysel
add pool link to bench (#5291)
b292c5c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattverse mattverse mattverse approved these changes

@p0mvn p0mvn p0mvn approved these changes

Assignees
No one assigned
Labels
A:no-changelog C:x/concentrated-liquidity V:state/compatible/no_backport State machine compatible PR, depends on prior breaks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@czarcas7ic @p0mvn @mattverse