Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto add changelog and backport labels to dependabot #5250

Merged
merged 4 commits into from
May 23, 2023

Conversation

pysel
Copy link
Member

@pysel pysel commented May 20, 2023

Closes: #5227

What is the purpose of the change

Adds labels to dependabot to avoid adding them manually

Testing and Verifying

Minor

Documentation and Release Note

Changelog

@pysel pysel requested a review from a team as a code owner May 20, 2023 12:56
@github-actions github-actions bot added the T:CI label May 20, 2023
@pysel pysel added the V:state/compatible/no_backport State machine compatible PR, depends on prior breaks label May 20, 2023
- package-ecosystem: gomod
directory: "/"
schedule:
interval: weekly
labels:
- "A:no-changelog"
- "V:state/compatible/no_backport"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as of my knowledge, it is not possible to add global labels, hence, here I have to duplicate labels from the previous package-ecosystem

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should be doing this for the go mod updates, they can be state breaking

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, I thought that the reviewer would change the label if the change is breaking, but I yeah your point makes sense, it is just better if we do not have labels for potentially breaking changes at all

Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call on this, I don't think we would need a changelog entry for this though!

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Matt, Park <[email protected]>
@p0mvn p0mvn merged commit f2a3612 into main May 23, 2023
@p0mvn p0mvn deleted the ruslan/dependabot-labels branch May 23, 2023 18:22
pysel added a commit that referenced this pull request Jun 6, 2023
* add labels

* changelog

* rm state compat label from gomod

* Update CHANGELOG.md

Co-authored-by: Matt, Park <[email protected]>

---------

Co-authored-by: Matt, Park <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:no-changelog T:CI V:state/compatible/no_backport State machine compatible PR, depends on prior breaks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: auto add changelog and backport labels to dependabot
4 participants