-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto add changelog and backport labels to dependabot #5250
Conversation
.github/dependabot.yml
Outdated
- package-ecosystem: gomod | ||
directory: "/" | ||
schedule: | ||
interval: weekly | ||
labels: | ||
- "A:no-changelog" | ||
- "V:state/compatible/no_backport" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as of my knowledge, it is not possible to add global labels, hence, here I have to duplicate labels from the previous package-ecosystem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should be doing this for the go mod updates, they can be state breaking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm, I thought that the reviewer would change the label if the change is breaking, but I yeah your point makes sense, it is just better if we do not have labels for potentially breaking changes at all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good call on this, I don't think we would need a changelog entry for this though!
Co-authored-by: Matt, Park <[email protected]>
* add labels * changelog * rm state compat label from gomod * Update CHANGELOG.md Co-authored-by: Matt, Park <[email protected]> --------- Co-authored-by: Matt, Park <[email protected]>
Closes: #5227
What is the purpose of the change
Adds labels to dependabot to avoid adding them manually
Testing and Verifying
Minor
Documentation and Release Note
Changelog