chore: lint tests in modules other than gamm #5207
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faddat
requested review from
mattverse,
stackman27,
nicolaslara,
p0mvn and
czarcas7ic
as code owners
github-actions
bot
added
C:CLI
C:x/concentrated-liquidity
C:x/epochs
C:x/incentives
C:x/tokenfactory
C:x/twap
faddat
added
V:state/compatible/no_backport
Closed
|
@mattverse -- fyi, I've tried "jiggling" the changelog reminder but to no avail. I think we are g2g here, and that #5127 can be looked at again after #5140. Oh noes the tests just failed :/ . Moment... |
|
@czarcas7ic should I use a different label or add a changelog? <3 tests passing |
github-actions
bot
removed
C:x/incentives
C:x/epochs
C:x/pool-incentives
C:x/concentrated-liquidity
C:x/tokenfactory
C:CLI
C:x/twap
github-actions
bot
added
C:app-wiring
github-actions
bot
added
C:x/gamm
|
Note: I really need to figure out what I am doing that breaks this... tomorrow |
|
Closing in favor of #5127 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Works toward closing, but does not close #5061
This PR is to keep momentum going without blocking on some type assertions in x/gamm. It lints all modules other
than x/gamm. Will continue on with x/gamm in #5127.
Testing and Verifying
If this passes the test suite, then it works because it focuses on linting tests.
Documentation and Release Note
No changelog because there's no change to the application.
Where is the change documented?
x/{module}/README.md)