-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lint all tests #5127
Closed
Closed
lint all tests #5127
Changes from 54 commits
Commits
Show all changes
158 commits
Select commit
Hold shift + click to select a range
70cfbdc
TestJoinSwapExactAmountInConsistency
DongLieu 37074cc
add cases corners
DongLieu f5dc71d
run golangci-lint and resolve ineffectual assignment to err
faddat 9fa7369
go work sync
faddat c688011
waypoint in "check all errors in tests"
faddat ac5bcd2
50 error checks remaining
faddat 3105a8a
42 errors remaining to check in tests
faddat cbed0c4
all tests pass and as many errors as possible have been checked
faddat 31327a6
revert enabling golangci-lint to check tests, as it would always fail…
faddat 2acfd0e
update changelog
faddat 1e9eb0c
use thelper in golangci-lint without linting every test
faddat d624769
Update tests/e2e/containers/containers.go
faddat e9c621f
Merge remote-tracking branch 'origin/main' into faddat/check-all-errors
faddat d616f90
thelper for incentives bench test
faddat 0a59632
unused code in tests
faddat 8ae270d
Update x/concentrated-liquidity/position_test.go
faddat ddc5487
Merge branch 'main' into faddat/check-all-errors
faddat 560388c
fix forced type assertions
faddat b70f80a
revert change to linter config
faddat b2d1fab
Update tests/e2e/e2e_test.go
faddat 85c7ecb
Update x/concentrated-liquidity/pool_test.go
faddat 8e573d7
skip pool = poolI
faddat eb9cc68
update swap_test.go to test that cl type assertions fail
faddat 56c6152
trial
faddat daa610e
we needed pool because it's used to CalcInGivenOut
faddat 93f5581
Merge branch 'main' into faddat/check-all-errors
faddat e243555
Merge remote-tracking branch 'origin/main' into faddat/check-all-errors
faddat 16c6c97
re-add skip state sync
faddat 39f6fc4
Merge branch 'faddat/unused-in-tests' into accumulate
faddat 6bc25aa
Merge branch 'faddat/forcetypeassert' into accumulate
faddat 268d276
everything but oddities
faddat a558e7b
Merge remote-tracking branch 'origin/main' into lint-all-tests
faddat ce1675f
Update CHANGELOG.md
faddat 66c0616
Merge branch 'main' into faddat/check-all-errors
faddat e7d37d0
more test cases for TestValidatePoolLiquidity()
DongLieu d05c314
return error in SetIncentiveRecord
faddat 1d07817
revert change to .golanci.yml
faddat 9d2ee5a
Update x/concentrated-liquidity/pool_test.go
faddat bc461ab
Update x/concentrated-liquidity/pool_test.go
faddat cb22e58
Update x/gamm/keeper/swap_test.go
faddat b9f45b1
Merge branch 'faddat/check-all-errors' into lint-all-tests
faddat 7ee03f6
Merge remote-tracking branch 'origin/faddat/forcetypeassert' into lin…
faddat 8ed22fc
golangci-lint run ./... --fix
faddat 2d93ccf
style: lint stableswap the same as the rest of osmosis (#5105)
faddat 20d9c04
Merge remote-tracking branch 'origin/main' into lint-all-tests
faddat 500ea1f
Add test cases for TestSwapOutAmtGivenIn()
DongLieu 624cadb
add return err for prepareCustomBalancerPool()
DongLieu f4d0555
add testcase with non zero exit fee
DongLieu 56e64ff
Merge remote-tracking branch 'origin/main' into lint-all-tests
faddat b6b2da4
res.liquidity
faddat 981eb4f
mask generated code from the linter, and fix makezero lint
faddat 665726f
almost :) - commit contains numerous small lint fixes for tests
faddat 5a5b16a
fix spelling mistake :)
faddat 179f100
Merge remote-tracking branch 'origin/main' into lint-all-tests
faddat beb40e5
Merge remote-tracking branch 'origin/main' into lint-all-tests
faddat b51a248
rename
DongLieu 365e8d2
add calculations lead to number
DongLieu 26260cd
remove testcase poolExitFee > 0
DongLieu 3f0c439
Merge remote-tracking branch 'origin/main' into lint-all-tests
faddat 8f99b2d
Merge remote-tracking branch 'origin/main' into lint-all-tests
faddat faf7fce
suite => s
faddat bc8434c
suite -> s
faddat 1bf171e
don't needlessly use fmt.Sprintf
faddat 4e130d6
Update x/concentrated-liquidity/incentives_test.go
faddat 9fe5b67
Update x/twap/export_test.go
faddat 931cce4
Update x/twap/export_test.go
faddat ef8811b
Merge remote-tracking branch 'origin/main' into lint-all-tests
faddat 6a6e558
Merge remote-tracking branch 'origin/main' into lint-all-tests
faddat 07442dc
sync
faddat 9732d6f
make all tests pass again
faddat 32cdbf7
remove swap_test.go from skipped files
faddat 14a97a9
Merge remote-tracking branch 'origin/main' into lint-all-tests
faddat 9fe383e
standardize the type assertions
faddat d4f65b6
lint cli_test.go
faddat 79094f2
Merge remote-tracking branch 'origin/main' into lint-all-tests
faddat 45cda39
Merge remote-tracking branch 'origin/main' into lint-all-tests
faddat 8427685
sync
faddat 58d260f
fix tests
faddat b32c43a
Merge remote-tracking branch 'origin/main' into lint-all-tests
faddat f5e7d33
Merge remote-tracking branch 'origin/main' into dong/issue3849
faddat 3273192
change linter settings
faddat 86d210a
Merge branch 'dong/issue3849' into lint-all-tests
faddat dc15a1a
Merge remote-tracking branch 'origin/main' into lint-all-tests
faddat 1e3d4b7
merge Dong's changes to x/gamm
faddat 23f4650
Revert "Merge branch 'dong/issue3849' into lint-all-tests"
faddat 01c7aca
Merge remote-tracking branch 'origin/main' into lint-all-tests
faddat 80207d4
merge main, sync start gamm over again
faddat d4badba
bookmark
faddat f8f5136
Merge remote-tracking branch 'origin/main' into lint-all-tests
faddat 508b973
save linting progress
faddat 4bb0346
s. to suite
faddat e74f277
fully passing
faddat cd4ba9c
Merge remote-tracking branch 'origin/main' into lint-all-tests
faddat 6c7694c
misc cleanup lets make sure we did not break e2e
faddat 44a8475
deprecation notices
faddat cf79dbe
lint cliq bench test
faddat 65e186e
cliq tests
faddat e7c8248
nolint the final two type assertions on chatgpt's advice
faddat c9caf07
Merge remote-tracking branch 'origin/main' into lint-all-tests
faddat 964857d
sync
faddat 1afd9a7
sync
faddat 83c40d1
Merge remote-tracking branch 'origin/main' into lint-all-tests
faddat d949a20
adjust run time for golangci and autofixes after merging main and acc…
faddat 906a746
Merge remote-tracking branch 'origin/main' into lint-all-tests
faddat 1cd43c7
sync
faddat 5296021
Merge remote-tracking branch 'origin/main' into lint-all-tests
faddat 94726e3
sync
faddat 509991f
Merge remote-tracking branch 'origin/main' into lint-all-tests
faddat 118930a
Merge remote-tracking branch 'origin/main' into lint-all-tests
faddat 77a7004
t.Helper() and b.Helper() + run golangci-lint ./... --fix
faddat 4e58f86
remove unused function
faddat 4e99ba6
remove unused functions, types, and fields in structs
faddat 3cc8284
eliminate naked returns
faddat 8241efe
eliminate naked returns
faddat 4233d0f
suite -> s
faddat ad0213f
ineffectual assignments
faddat fa88191
misspelling and double imports
faddat 908378e
cleanup (check errors and suite -> s)
faddat 2838c57
Merge remote-tracking branch 'origin/main' into lint-all-tests
faddat 5eb6ce2
Merge remote-tracking branch 'origin/main' into lint-all-tests
faddat 03c0630
lint
faddat 83bcdbb
merge succeded, this is cleanup of various lints
faddat 30acea9
remove unused
faddat d4d12fb
make lint work in ci
faddat 9d36046
Merge remote-tracking branch 'origin/main' into lint-all-tests
faddat b6aed98
autofixes
faddat 6c9098a
Merge remote-tracking branch 'origin/main' into lint-all-tests
faddat 12d7037
Merge remote-tracking branch 'origin/main' into lint-all-tests
faddat ed76fc5
fix foced type assertions and the "always zero" issue
faddat b6922a4
remove fuzzstate type
faddat f962856
rename swapAmountsMismatchErr swapAmountsMismatchError
faddat 2c192df
linting v16 completed
faddat 70e2cf6
fix randChangePercent (thanks @valardragon)
faddat a313b77
fix e2e tests
faddat 92fe433
use t.Parallel correctly
faddat ca73d11
add a note about parallel e2e tests, and don't call t.Parallel()
faddat 269bb4d
lengthen timeout for linter
faddat b21981e
Merge remote-tracking branch 'origin/main' into lint-all-tests
faddat de3762b
Merge remote-tracking branch 'origin/main' into lint-all-tests
faddat 5412a54
lockuptypes
faddat d7fcf5b
bump linter
faddat d7474d5
Merge remote-tracking branch 'origin/main' into lint-all-tests
faddat 82f6550
Merge remote-tracking branch 'origin/main' into lint-all-tests
faddat 194768b
Merge remote-tracking branch 'origin/main' into lint-all-tests
faddat bec5434
tidy
faddat bc248ae
sync and tidy
faddat 98805e5
check errors
faddat df564ad
Merge remote-tracking branch 'origin/main' into lint-all-tests
faddat e9dbf9c
lint latest merge from main
faddat 7aa9f0c
Merge remote-tracking branch 'origin/main' into lint-all-tests
faddat 0b2c113
fix white space and double import
faddat c725bd1
Merge remote-tracking branch 'origin/main' into lint-all-tests
faddat 87beb96
Merge remote-tracking branch 'origin/main' into lint-all-tests
faddat be8c21f
Merge remote-tracking branch 'origin/main' into lint-all-tests
faddat 1f0e28d
lint tests with unparam
faddat 434575d
remove another unused parameter
faddat f2e2b8c
Merge remote-tracking branch 'origin/main' into lint-all-tests
faddat aa81fb6
go work sync
faddat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are these tests skipped?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those tests are skipped because the code generation currently makes a whole lot of deprecated code. In order to fix that, we would just need to update the query generator I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way, looking at this list, I'm not 100% sure about the swap test file. I can have another look at it tomorrow. Try to figure out why that one is there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have this reduced to just the generated queries.