Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use os.ReadFile instead of ioutil.ReadFile #5113

Merged
merged 1 commit into from
May 8, 2023
Merged

use os.ReadFile instead of ioutil.ReadFile #5113

merged 1 commit into from
May 8, 2023

Conversation

faddat
Copy link
Member

@faddat faddat commented May 7, 2023 •
edited
Loading

What is the purpose of the change

Remove ioutil because it is deprecated

Testing and Verifying

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? no
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no
  • How is the feature or change documented? not applicable

@faddat faddat added no-changelog V:state/compatible/backport State machine compatible PR, should be backported A:backport/v15.x backport patches to v15.x branch labels May 7, 2023
@faddat faddat mentioned this pull request May 8, 2023
Closed
@p0mvn p0mvn merged commit 1afdd6a into main May 8, 2023
@p0mvn p0mvn deleted the faddat/remove-ioutil branch May 8, 2023 13:06
mergify bot pushed a commit that referenced this pull request May 8, 2023
@faddat @mergify
use os.ReadFile instead of ioutil.ReadFile (#5113)
81a1808 
(cherry picked from commit 1afdd6a)

# Conflicts:
#	x/tokenfactory/keeper/before_send_test.go
@mergify mergify bot mentioned this pull request May 8, 2023
Closed
pysel pushed a commit that referenced this pull request Jun 6, 2023
@faddat @pysel
use os.ReadFile instead of ioutil.ReadFile (#5113)
61fd509
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pysel pysel pysel approved these changes

@p0mvn p0mvn p0mvn approved these changes

@mattverse mattverse Awaiting requested review from mattverse mattverse is a code owner

@nicolaslara nicolaslara Awaiting requested review from nicolaslara nicolaslara is a code owner

Assignees
No one assigned
Labels
A:backport/v15.x backport patches to v15.x branch C:x/tokenfactory V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@faddat @p0mvn @pysel