-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use cosmossdk.io/errors #5065
Conversation
regarding labels: only backport this to v15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me (pretty straightforward) but left some small comments
@nicolaslara sir, do you have any idea what might be making my editor defy me? I didn't make the change to the backlog link..... I'll manually fix but suspect it happened because I hit ctrl+s -- will look into it from my end too (maybe markdownlint?) |
lol, yeah, no idea. I've had my editor do stuff like that too. If the editor refuses I can fix it (emacs! :) ) |
@nicolaslara I've fixed it -- those links had a space between ] and ( so my editor did magic to them |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you
* use cosmossdk.io/errors * update changelog * fix links so they don't violate no-bare-url (cherry picked from commit 560224f) # Conflicts: # CHANGELOG.md # app/params/config.go # go.mod # go.sum # osmomath/go.mod # osmoutils/go.mod # tests/cl-genesis-positions/go.mod # tests/cl-go-client/go.mod # tests/cl-go-client/go.sum # x/concentrated-liquidity/incentives_test.go # x/cosmwasmpool/model/msgs.go # x/epochs/go.mod # x/epochs/go.sum # x/gamm/handler.go # x/gamm/keeper/migrate_test.go # x/gamm/pool-models/balancer/msgs.go # x/ibc-hooks/go.mod # x/ibc-hooks/go.sum # x/pool-incentives/types/errors.go # x/superfluid/keeper/migrate_test.go # x/superfluid/keeper/stake_test.go # x/superfluid/keeper/superfluid_asset_store.go # x/superfluid/types/msgs.go # x/tokenfactory/keeper/before_send.go # x/tokenfactory/types/errors.go # x/tokenfactory/types/msgs.go
* use cosmossdk.io/errors * update changelog * fix links so they don't violate no-bare-url
What is the purpose of the change
Make upgrading to sdk v0.47.x easier by adopting cosmossdk.io/errors where applicable while
still using sdk v0.45.x
Brief Changelog
Testing and Verifying
This should pass all existing tests without issue
Documentation and Release Note
Unreleased
section inCHANGELOG.md
? yes