Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Simulator] Change stakingTypes.BankKeeper to simtypes.BankKeeper #5028

Merged
merged 3 commits into from
May 1, 2023
Merged

[Simulator] Change stakingTypes.BankKeeper to simtypes.BankKeeper #5028

merged 3 commits into from
May 1, 2023

Conversation

phamminh0811
Copy link
Contributor

Closes: #4184

What is the purpose of the change

As discussed in #4768, we donot necessarily have to use bankKeeper from cosmos-sdk instead we can keep the interface and use simtypes.BankKeeper. So this PR changes everything related to stakingTypes.BankKeeper to simtypes.BankKeeper.

Testing and Verifying

This change is already covered by existing tests.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? (yes / no)
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? (yes / no)
  • How is the feature or change documented? (not applicable / specification (x/<module>/spec/) / Osmosis docs repo / not documented)

@github-actions github-actions bot added C:app-wiring Changes to the app folder C:simulator Edits simulator or simulations C:x/incentives C:x/lockup C:x/superfluid labels Apr 30, 2023
@phamminh0811 phamminh0811 mentioned this pull request Apr 30, 2023
Closed
@phamminh0811 phamminh0811 added the V:state/compatible/backport State machine compatible PR, should be backported label Apr 30, 2023
stackman27
stackman27 approved these changes May 1, 2023
View reviewed changes
Copy link
Contributor

@stackman27 stackman27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM

want to make sure we can add any bankKeeper methods in simtypes/app.go bankKeeper interface. for instance we couldn't add SetDenomMetadata before

@p0mvn p0mvn merged commit 186bee7 into osmosis-labs:main May 1, 2023
@p0mvn p0mvn mentioned this pull request May 1, 2023
Merged
@p0mvn
Copy link
Member

p0mvn commented May 1, 2023

Thanks for refreshing getting this in so quickly @phamminh0811

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p0mvn p0mvn p0mvn approved these changes

@stackman27 stackman27 stackman27 approved these changes

@mattverse mattverse Awaiting requested review from mattverse mattverse is a code owner

@czarcas7ic czarcas7ic Awaiting requested review from czarcas7ic czarcas7ic is a code owner

Assignees
No one assigned
Labels
C:app-wiring Changes to the app folder C:simulator Edits simulator or simulations C:x/incentives C:x/lockup C:x/superfluid V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Simulator] User bankKeeper.Keeper instead of simtypes.BankKeeper
3 participants
@phamminh0811 @p0mvn @stackman27